-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using and operator vs fuzzy_and while querying assumptions #8500
Comments
Ditto with or and not. This is another case where the new assumptions are cleaner. |
Yes, >>> None or False
False
>>> False or None
>>> and this is a problem too: >>> not None
True In the end, for old assumptions - we can't use python's boolean operations at all. |
Where can I find information about the "new" assumptions? |
sympy/assumptions |
It's ok to use |
Yes, but we still have errors. I hope I was careful enough for And, but we have Or and Not cases too... |
close sympy/sympy#3112 (MrvAsympt was added in diofant#6) close sympy/sympy#9173 (test was added in 5a510ac) close sympy/sympy#9808 (fixed in 09e539b) close sympy/sympy#9341 (fixed in af98a00) close sympy/sympy#9908 (fixed in cc3fa8d) close sympy/sympy#6171 (test added in d278031) close sympy/sympy#9276 (diagnose_imports.py removed in ab8c535) close sympy/sympy#10201 (fixed in 0d0fc5f) close sympy/sympy#9057 (test was added in 8290a0c) close sympy/sympy#11159 (test was added in ffb76cb) close sympy/sympy#2839 (new AST transformers are used, see diofant#278 and diofant#167) close sympy/sympy#11081 (see ed01e16 and bb92329) close sympy/sympy#10974 (see 73fc425) close sympy/sympy#10806 (test in 539929a) close sympy/sympy#10801 (test in 2fe3da5) close sympy/sympy#9549 (test in 88bdefa) close sympy/sympy#4231 (test was added in fb411d5) close sympy/sympy#8634 (see 2fcbb58) close sympy/sympy#8481 (see 1ef20d3) close sympy/sympy#9956 (fixed in a34735f) close sympy/sympy#9747 (see e117c60) close sympy/sympy#7853 (see 3e4fbed) close sympy/sympy#9634 (see 2be03f5) close sympy/sympy#8500 (fixed in diofant#104 and finally in diofant#316) close sympy/sympy#9192 (see 9bf622f) close sympy/sympy#7130 (see e068fa3) close sympy/sympy#8514 (see b2d543b) close sympy/sympy#9334 (see 90de625) close sympy/sympy#8229 (see 9755b89) close sympy/sympy#8061 (see 7054f06) close sympy/sympy#7872 (tested in diofant#6) close sympy/sympy#3496 (tested in test_log_symbolic) close sympy/sympy#2929 (see da7db7a) close sympy/sympy#8203 (oo is not a real, see diofant#36) close sympy/sympy#7649 (0 is imaginary since diofant#8) close sympy/sympy#7256 (fixed in c0a4549) close sympy/sympy#6783 (see cb28d63) close sympy/sympy#5662 (is_integer issue fixed in 6bfa9f8, there is no is_bounded anymore) close sympy/sympy#5295 (fixed with diofant#354) close sympy/sympy#4856 (we now have flake/pep tests) close sympy/sympy#4555 (flake8 enabled after diofant#214) close sympy/sympy#5773 (cmp_to_key removed after diofant#164 and c9acbf0) close sympy/sympy#5484 (see above) Added regression tests: from https://groups.google.com/forum/#!topic/sympy/LkTMQKC_BOw fixes sympy/sympy#8825 (probably via diofant#209) fixes sympy/sympy#8635 fixes sympy/sympy#8157 fixes sympy/sympy#7872 fixes sympy/sympy#7599 fixes sympy/sympy#6179 fixes sympy/sympy#5415 fixes sympy/sympy#2865 fixes sympy/sympy#5907 fixes sympy/sympy#11722 Closes diofant#347
close sympy/sympy#3112 (MrvAsympt was added in diofant#6) close sympy/sympy#9173 (test was added in 5a510ac) close sympy/sympy#9808 (fixed in 09e539b) close sympy/sympy#9341 (fixed in af98a00) close sympy/sympy#9908 (fixed in cc3fa8d) close sympy/sympy#6171 (test added in d278031) close sympy/sympy#9276 (diagnose_imports.py removed in ab8c535) close sympy/sympy#10201 (fixed in 0d0fc5f) close sympy/sympy#9057 (test was added in 8290a0c) close sympy/sympy#11159 (test was added in ffb76cb) close sympy/sympy#2839 (new AST transformers are used, see diofant#278 and diofant#167) close sympy/sympy#11081 (see ed01e16 and bb92329) close sympy/sympy#10974 (see 73fc425) close sympy/sympy#10806 (test in 539929a) close sympy/sympy#10801 (test in 2fe3da5) close sympy/sympy#9549 (test in 88bdefa) close sympy/sympy#4231 (test was added in fb411d5) close sympy/sympy#8634 (see 2fcbb58) close sympy/sympy#8481 (see 1ef20d3) close sympy/sympy#9956 (fixed in a34735f) close sympy/sympy#9747 (see e117c60) close sympy/sympy#7853 (see 3e4fbed) close sympy/sympy#9634 (see 2be03f5) close sympy/sympy#8500 (fixed in diofant#104 and finally in diofant#316) close sympy/sympy#9192 (see 9bf622f) close sympy/sympy#7130 (see e068fa3) close sympy/sympy#8514 (see b2d543b) close sympy/sympy#9334 (see 90de625) close sympy/sympy#8229 (see 9755b89) close sympy/sympy#8061 (see 7054f06) close sympy/sympy#7872 (tested in diofant#6) close sympy/sympy#3496 (tested in test_log_symbolic) close sympy/sympy#2929 (see da7db7a) close sympy/sympy#8203 (oo is not a real, see diofant#36) close sympy/sympy#7649 (0 is imaginary since diofant#8) close sympy/sympy#7256 (fixed in c0a4549) close sympy/sympy#6783 (see cb28d63) close sympy/sympy#5662 (is_integer issue fixed in 6bfa9f8, there is no is_bounded anymore) close sympy/sympy#5295 (fixed with diofant#354) close sympy/sympy#4856 (we now have flake/pep tests) close sympy/sympy#4555 (flake8 enabled after diofant#214) close sympy/sympy#5773 (cmp_to_key removed after diofant#164 and c9acbf0) close sympy/sympy#5484 (see above) Added regression tests: from https://groups.google.com/forum/#!topic/sympy/LkTMQKC_BOw fixes sympy/sympy#8825 (probably via diofant#209) fixes sympy/sympy#8635 fixes sympy/sympy#8157 fixes sympy/sympy#7872 fixes sympy/sympy#7599 fixes sympy/sympy#6179 fixes sympy/sympy#5415 fixes sympy/sympy#2865 fixes sympy/sympy#5907 fixes sympy/sympy#11722 Closes diofant#347
No activity. I believe, this is fixed in the diofant, so it's not a problem for me. Closed. |
Although this may not be a problem for diofant it should be checked in SymPy to see if these issue still exist. |
The problem is that builtin and operator is not symmetric wrt non-boolean args, esp. None:
That's important if we consider assumptions. We have a lot of statements like
self.is_integer and other.is_integer
in the code (see, for example, some cases in the core). It seems, this is a wrong pattern and we should usefuzzy_and
instead.Thanks to @smichr who brings my attention to this in #8490.
The text was updated successfully, but these errors were encountered: