New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Joints framework documentation #23730
Conversation
✅ Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.11. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
🟠Hi, I am the SymPy bot (v167). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files:
If these files were added/deleted on purpose, you can ignore this message. |
ca5b71a
to
34dd082
Compare
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) before after ratio
[77f1d79c] [806603dc]
<sympy-1.10.1^0>
+ 27.9±0.4μs 75.3±3μs 2.70 matrices.TimeMatrixExpression.time_MatAdd
+ 129±3ms 224±4ms 1.74 sum.TimeSum.time_doit
Full benchmark results can be found as artifacts in GitHub Actions |
19ac2c6
to
09191ff
Compare
For the child body these are called the ``child_point`` and ``child_joint_pos``. | ||
The orientation of the joint in each body is defined by the ``parent_axis`` and ``child_axis``. | ||
These two vectors are aligned as explained in the :class:`~.Joint` notes and are in the image parallel to the orange vector. | ||
As last the joint also needs :func:`~.dynamicsymbols` as generalized coordinates and speeds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess people could create these joints to just get static connections of bodies, so having a dynamicsymbol isn't strictly needed.
Make both png and svg. Fix the few notes and this is good. |
a0bfecd
to
abd14ff
Compare
There are some more pngs, but this one is a bit excessive in size:
|
@tjstienstra I know you have a nice way of drawing these figures, but I think we need to stick to svg figures that are editable. We already seem to have a not so great precedent set with some images in the physics docs. |
Okay, than I'll go and work on some SVGs this week to replace them. |
References to other Issues or PRs
Brief description of what is fixed or changed
Fixes #21705.
Add general explanation about the joints framework within the physics/mechanics module.
Add images explaining the
PinJoint
andPrismaticJoint
.Add the
JointsMethod
docstring to the online documentation.Other comments
Release Notes