Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Joint images to SVG #23890

Merged
merged 1 commit into from Aug 10, 2022
Merged

[GSoC] Joint images to SVG #23890

merged 1 commit into from Aug 10, 2022

Conversation

tjstienstra
Copy link
Contributor

@tjstienstra tjstienstra commented Aug 8, 2022

References to other Issues or PRs

Improves #23730

Brief description of what is fixed or changed

This PR replaces the PNG images introduced in #23730 for SVG, which have a small file size.

Other comments

Release Notes

  • other
    • Replace PNG joint images for SVG

@sympy-bot
Copy link

sympy-bot commented Aug 8, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Improves #23730


#### Brief description of what is fixed or changed
This PR replaces the PNG images introduced in #23730 for SVG, which have a small file size.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* other
   * Replace PNG joint images for SVG
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@sympy-bot
Copy link

sympy-bot commented Aug 8, 2022

🟠

Hi, I am the SymPy bot (v167). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it.

This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75.

The following commits delete files:

  • 997a590:
    • doc/src/modules/physics/mechanics/api/PinJoint.png
    • doc/src/modules/physics/mechanics/api/PrismaticJoint.png

If these files were added/deleted on purpose, you can ignore this message.

@tjstienstra tjstienstra changed the title [GSoC] [GSoC] Joint images to SVG Aug 8, 2022
@tjstienstra
Copy link
Contributor Author

@moorepants here is the PR, which should satisfy your request.

@sidhu1012 @brocksam

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@smichr
Copy link
Member

smichr commented Aug 10, 2022

This looks nice. If other changes need to be made a new issue can be opened. Thank you.

@smichr smichr merged commit 0940014 into sympy:master Aug 10, 2022
@tjstienstra tjstienstra deleted the MechanicsToSVG branch August 23, 2022 08:50
@moorepants moorepants added the CZI: Codegen/Biomech Sam Brockie's CZI-funded postdoc work on codegen and biomechanics label Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CZI: Codegen/Biomech Sam Brockie's CZI-funded postdoc work on codegen and biomechanics physics.mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants