Ping can now optionally filter by workload ID or name #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a variant of this where we reused the same |
Signed-off-by: Kevin Hoffman <autodidaddict@users.noreply.github.com>
jordan-rash
approved these changes
Apr 19, 2024
jordan-rash
pushed a commit
that referenced
this pull request
Apr 19, 2024
* can now ping a nexus to find where a workload Id is running * can use either workload ID or workload name for filter * Update client.go Signed-off-by: Kevin Hoffman <autodidaddict@users.noreply.github.com> --------- Signed-off-by: Kevin Hoffman <autodidaddict@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now use a different
WPINGendpoint to have nodes only reply to a ping if they're currently running the indicated workload, which can be the workload ID or the workload name.So if you specify a workload ID, you should expect 0 or 1 nodes.
If you specify a workload name, you might get multiple nodes if that workload is scaled out.
Added the
--workloadoption to thenode lscommand, so the end user doesn't need to know that this is a different ping subject under the hood.