Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconfigure Default Workload Types #240

Merged
merged 12 commits into from
May 22, 2024
Merged

Reconfigure Default Workload Types #240

merged 12 commits into from
May 22, 2024

Conversation

jordan-rash
Copy link
Contributor

No description provided.

@jordan-rash
remove elf and create workload type
65ebe3c 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
update error message
2a24753 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
fix windows
bc8e0ce 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
node capabilities
7be7fa5 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
add tags
bd4b77c 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
autodidaddict
autodidaddict previously approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@autodidaddict autodidaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice and clean. I like the newtype for workload type string.

@jordan-rash
add capabilities to node
f06f5c8 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
autodidaddict
autodidaddict previously approved these changes May 22, 2024
View reviewed changes
kthomas
kthomas reviewed May 22, 2024
View reviewed changes
internal/models/cli.go Outdated Show resolved Hide resolved
@jordan-rash
change node default workload
07094ba 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
kyles wishes come true
2c6aaef 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
doesnt seem needed
8fdbfc9 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
fix windows test
25f4463 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
fix windows test
8d9e089 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash
fix windows test
86950fc 
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
@jordan-rash jordan-rash marked this pull request as ready for review May 22, 2024 19:58
@jordan-rash jordan-rash requested a review from a team as a code owner May 22, 2024 19:58
kthomas
kthomas approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@kthomas kthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

🚀 🎸

@jordan-rash jordan-rash merged commit f69aefe into main May 22, 2024
4 checks passed
@jordan-rash jordan-rash deleted the fix/default_workload_types branch May 22, 2024 20:04
@jordan-rash jordan-rash mentioned this pull request May 22, 2024
Closed
@jordan-rash jordan-rash linked an issue May 22, 2024 that may be closed by this pull request
Default Workload Types Innaccurate #234
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kthomas kthomas kthomas approved these changes

@autodidaddict autodidaddict autodidaddict left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Workload Types Innaccurate
3 participants
@jordan-rash @kthomas @autodidaddict