Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functionalComponents property from Interaction #438

Open
manulera opened this issue Apr 12, 2024 · 2 comments
Open

Remove functionalComponents property from Interaction #438

manulera opened this issue Apr 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@manulera
Copy link
Member

Related to SynBioDex/SBOL-utilities#248
@jakebeal jakebeal added the bug Something isn't working label Apr 12, 2024
@tcmitchell
Copy link
Collaborator

@jakebeal this will break the intentional bug-for-bug compatibility with pySBOL/libSBOL. libSBOL has a functionalComponents property on Interaction: https://github.com/SynBioDex/libSBOL/blob/master/source/interaction.h#L49

You can remove this property, and you should be aware of the ramifications before doing so.

@jakebeal
Copy link
Collaborator

Thanks, @tcmitchell - that's good to know.

Do you think there's a way to support the libSBOL bug while avoiding future confusion by marking it as deprecated or something of the sort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tcmitchell @jakebeal @manulera