Add database keepalive pings. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some microservice infrastructure configurations (notably, our usage of istio on kubernetes) will detect long-running idle connections and kill them. This causes an issue with the connection pooling implemented by some sql.DB drivers that will assume that once a connection is open it will remain open indefinitely. This commit adds the SendKeepalivePings func to our database package so that we can periodically send lightweight database queries and prevent the connection from getting killed. (+semver: feature) Signed-off-by: Jeff Cuevas-Koch <jeff@cuevaskoch.com>
cuevaskoch
requested review from
dkaminski,
thzinc,
glenwperry,
k-grant and
StephenBondor
thzinc
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some microservice infrastructure configurations (notably, our usage of istio on
kubernetes) will detect long-running idle connections and kill them. This
causes an issue with the connection pooling implemented by some sql.DB drivers
that will assume that once a connection is open it will remain open
indefinitely.
This commit adds the SendKeepalivePings func to our database package so that we
can periodically send lightweight database queries and prevent the connection
from getting killed.
(+semver: feature)
Signed-off-by: Jeff Cuevas-Koch jeff@cuevaskoch.com