Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: Describe new event types PendingDevicesChanged and PendingFoldersChanged. #592

Merged
merged 5 commits into from Jan 11, 2021

Conversation

acolomb
Copy link
Member

@acolomb acolomb commented Dec 17, 2020

Correlated to syncthing/syncthing#7205.

The previous DeviceRejected and FolderRejected events are marked as deprecated with a hint linking to the new events.

@acolomb acolomb changed the title events: Describe new event type FolderOfferCancelled. events: Describe new event types PendingDevicesChanged and PendingFoldersChanged. Dec 23, 2020
@calmh calmh merged commit 14eebfb into syncthing:main Jan 11, 2021
@acolomb
Copy link
Member Author

acolomb commented Jan 11, 2021

@calmh Note that the corresponding implementation is not on the main branch yet, see syncthing/syncthing#7205.

calmh added a commit that referenced this pull request Jan 11, 2021
@calmh
Copy link
Member

calmh commented Jan 11, 2021

Ugh. I naively thought this went in with the move of the pending stuff to the database. (Looking at that linked PR I don't see what the event changes has to do with the PR subject...)

@acolomb
Copy link
Member Author

acolomb commented Jan 11, 2021

Yeah, it was an indirect consequence of @AudriusButkevicius objecting to a new FolderOfferCancelled event, which this PR was originally about.

@calmh
Copy link
Member

calmh commented Jan 11, 2021

This PR should be reopened as I removed the commit in question, but that's not possible. You probably need to file a new one. Sorry for the mess.

@acolomb
Copy link
Member Author

acolomb commented Jan 11, 2021

I had hoped that the syncthing/syncthing#7205 could be merged for v1.13 as well.

No problem, will squeeze in a timely new docs PR whenever the main PR is merged.

@calmh
Copy link
Member

calmh commented Jan 11, 2021

This problem will go away once I dictatorially decide to merge the docs and syncthing repos over everyones objections. 😬

@acolomb
Copy link
Member Author

acolomb commented Jan 11, 2021

This problem will go away once I dictatorially decide to merge the docs and syncthing repos over everyones objections.

If a side-effect of that would be easy access to a specific release's documentation, I'd say "Go dictator!" :-) In fact, the CI is probably where the hard questions would need to be solved...

@acolomb
Copy link
Member Author

acolomb commented Jan 11, 2021

New PR is #597.

@acolomb acolomb deleted the event-folder-offer-cancelled branch January 11, 2021 16:25
@acolomb
Copy link
Member Author

acolomb commented Jan 11, 2021

Ugh. I naively thought this went in with the move of the pending stuff to the database. (Looking at that linked PR I don't see what the event changes has to do with the PR subject...)

@calmh I see you already tagged v1.13.0-rc.1, thought that would happen on Tuesday? Anyway, the release notes should not mention these new event types, as they were not really merged on the main repo.

@calmh
Copy link
Member

calmh commented Jan 11, 2021

I tag the day before release. The release notes won't mention the events, thought the rc1 tag message will because I tagged before this debacle.

@acolomb
Copy link
Member Author

acolomb commented Jan 11, 2021

Thanks for the clarification :-)

AudriusButkevicius pushed a commit that referenced this pull request Jan 25, 2021
#597)

* events: New events PendingDevicesChanged and PendingFoldersChanged.

* events: Mark ...Rejected events deprecated and link to replacements.

* events: Add versionadded note to the new event types.

For now only a guess, since it didn't make it for v1.13.
calmh added a commit that referenced this pull request Mar 9, 2021
* main: (21 commits)
  Remove dead Badger experiment
  users/config: Describe QUIC address config (#618)
  Mention QUIC related port (#617)
  dev/release-creation: Adjust to changes to grt tool
  dev/building: Update go version to 1.16 (#614)
  dev/building: Add Windows and Android prerequisite information (#615)
  Update versioning.rst (#613)
  users/config: Add a warning to ignoreDelete (#608)
  users/versioning: Improve external versioning example script for Windows (#606)
  gui: Make terms bold in definition lists for better visibility (#609)
  dev/rest: Update db/browse example
  dev/release-creation: Create new milestone
  users/config: Use backslashes for Windows paths (#603)
  users/config: Improve modTimeWindowS explanation (#584)
  users/foldertypes: Button wording (#602)
  events: Add PendingDevicesChanged and PendingFoldersChanged (ref #592) (#597)
  users/config: Document decoupled database + config (fixes #571) (#600)
  users/stdiscosrv, users/strelaysrv: Better documentation how to obtain the binaries. (#601)
  advanced/folder-ignoredelete: Add a warning about using ignoreDelete (#598)
  rest: API for pending devices and folders. (#498)
  ...
@syncthing syncthing locked and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants