Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users/versioning: Improve external versioning example script for Windows #606

Merged
merged 1 commit into from Feb 12, 2021

Conversation

tomasz1986
Copy link
Contributor

Enable UTF-8 support, as otherwise the script will fail with non-native
code pages, e.g. when using non-Latin characters in the English version
of Windows, etc. Use quotes with the "set" command or the script will be
unable to deal with funky characters like "&" in file and folder names.
Use "md" instead of "mkdir", because it is shorter. Lastly, use "rem"
instead of "::" for comments, as this is the only way to comment that
is recommended by Microsoft (and "::" is just a hack in itself).

Signed-off-by: Tomasz Wilczyński twilczynski@naver.com

Enable UTF-8 support, as otherwise the script will fail with non-native
code pages, e.g. when using non-Latin characters in the English version
of Windows, etc. Use quotes with the "set" command or the script will be
unable to deal with funky characters like "&" in file and folder names.
Use "md" instead of "mkdir", because it is shorter. Lastly, use "rem"
instead of "::" for comments, as this is the only way to comment that
is recommended by Microsoft (and "::" is just a hack in itself).

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
@tomasz1986
Copy link
Contributor Author

There are still some more wacky characters in addition to & that will make the script fail (despite the quotes), but I cannot remember them right now. I will do another PR if they come to my mind later.

@imsodin imsodin merged commit 72b0e6f into syncthing:main Feb 12, 2021
@tomasz1986 tomasz1986 deleted the tomasz86-versioningbatchquotes branch February 12, 2021 16:51
calmh added a commit that referenced this pull request Mar 9, 2021
* main: (21 commits)
  Remove dead Badger experiment
  users/config: Describe QUIC address config (#618)
  Mention QUIC related port (#617)
  dev/release-creation: Adjust to changes to grt tool
  dev/building: Update go version to 1.16 (#614)
  dev/building: Add Windows and Android prerequisite information (#615)
  Update versioning.rst (#613)
  users/config: Add a warning to ignoreDelete (#608)
  users/versioning: Improve external versioning example script for Windows (#606)
  gui: Make terms bold in definition lists for better visibility (#609)
  dev/rest: Update db/browse example
  dev/release-creation: Create new milestone
  users/config: Use backslashes for Windows paths (#603)
  users/config: Improve modTimeWindowS explanation (#584)
  users/foldertypes: Button wording (#602)
  events: Add PendingDevicesChanged and PendingFoldersChanged (ref #592) (#597)
  users/config: Document decoupled database + config (fixes #571) (#600)
  users/stdiscosrv, users/strelaysrv: Better documentation how to obtain the binaries. (#601)
  advanced/folder-ignoredelete: Add a warning about using ignoreDelete (#598)
  rest: API for pending devices and folders. (#498)
  ...
@syncthing syncthing locked and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants