-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder Factories #3029
Folder Factories #3029
Conversation
Haven't read the code yet but this sounds like a good idea. Probably negatory on the name change to read only though - that was the first name which literally no one understood. Take a look at the issue for sorting out the name, I think we settled on something like "send changes only" or so |
I don't understand how people don't understand it tho. We also have the help text at the bottom, explaining what it is and a link to help, is that not enough? |
As an alternative we can call it |
Feels more like |
Without reading it yet. My first reaction was "finally someone else had the same idea". (I already started a PR with the same intent.) |
Reverted back to master. |
@@ -23,6 +23,9 @@ const ( | |||
OldestHandledVersion = 10 | |||
CurrentVersion = 13 | |||
MaxRescanIntervalS = 365 * 24 * 60 * 60 | |||
|
|||
FolderTypeReadWrite = "readwrite" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem to fit better into folder.go
(folderTypeXY to folder)
@st-review merge this, I'll fixup the type in next commit |
👌 Merged as eabd2fc. Thanks, @AudriusButkevicius! |
I always felt we were imprisoned by a boolean flag, hence this change.
Also, a bit of a longshot, but I am dropping the Folder Master business and calling things their real names, as I don't think Master has any better meaning than Read Only, actually the opposite, I think it causes for confusion as Master implies authoritative, which it isn't.