Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build on stable #5

Closed

Conversation

macisamuele
Copy link

The main goal of this PR is to ensure that the library could be used on stable release.

In order to achieve so I removed the explicit request for the proc_macro feature gate as it has been stabilised in rustc 1.29; the presence of such gate would cause cargo +stable build to fail.

To prevent regressions I made sure that:

  • tests will be continuously run on stable and nightly releases
  • documentation is tested (so we can guarantee that the provided examples are actually working)

@synek317
Copy link
Owner

Thank you very much! This is a huge step towards v. 1.0 which I was thinking about but had no time.

@macisamuele
Copy link
Author

@synek317 do you have an estimation on when this PR could be merged?
I don't see opened issues and I would love to use a released version instead of continuing to rely on a personal git repo :)

@macisamuele
Copy link
Author

Hey @synek317, sorry for pinging you again.
Do we have a timeline for this?
I would like to use the library for running tests on rust-stable and this PR would help

@macisamuele
Copy link
Author

macisamuele commented Jul 25, 2019

@synek317 do we have updates on this?
I would love to have this merged as this enables using the library while running tests with rust stable.

@frondeus
Copy link

Hello, sorry for no answer.

I agreed with Marcin that I'll take care of this project.
Right now you can use test-case = "0.3.0" which brings your changes.

However there are some breaking changes like replacing :: with ; in macro attribute.
Feel free to leave a comment there :)

@synek317 will soon deprecate this crate in favor of mine.

@macisamuele
Copy link
Author

@frondeus good to know. I'll give a try to the new crate and open issues there in case of need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants