Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused synfig::rendering::Resource #3074

Merged
merged 1 commit into from
May 10, 2023
Merged

refactor: remove unused synfig::rendering::Resource #3074

merged 1 commit into from
May 10, 2023

Conversation

rodolforg
Copy link
Contributor

and its parent class etl::virtual_shared_object

@rodolforg
refactor: remove unused synfig::rendering::Resource
9a907b5 
and its parent class etl::virtual_shared_object
mohamedAdhamc
mohamedAdhamc approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@mohamedAdhamc mohamedAdhamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just a quick note related to the description since virtual_shared_object is the parent of Resource::Storage not Resource I think it wouldn't hurt to make the description clearer regarding that.

@ice0 ice0 merged commit 1171954 into synfig:master May 10, 2023
@ice0
Copy link
Collaborator

ice0 commented May 10, 2023

Merged. Thank you!

@rodolforg rodolforg deleted the remove-unused-rendering-resource branch May 10, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedAdhamc mohamedAdhamc mohamedAdhamc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodolforg @ice0 @mohamedAdhamc