Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateManager.Instance.BaseUrl is not accessible #98

Closed
suren1525 opened this issue May 19, 2017 · 1 comment
Closed

UpdateManager.Instance.BaseUrl is not accessible #98

suren1525 opened this issue May 19, 2017 · 1 comment

Comments

@suren1525
Copy link

suren1525 commented May 19, 2017 •
edited
Loading

I want to write my own UpdateTask
MyUpdateTask : UpdateTaskBase

In my UpdateTask I need access to UpdateManager.Instance.BaseUrl as it is done in FileUpdateTask
string baseUrl = UpdateManager.Instance.BaseUrl;
but BaseUrl is internal :(
Could you make it public?
Thanks
@synhershko
Copy link
Owner

If you want to submit a PR we will gladly accept it

suren1525 added a commit to suren1525/NAppUpdate that referenced this issue Aug 29, 2018
@suren1525
Update UpdateManager.cs
35ec78c 
synhershko#98
@suren1525 suren1525 mentioned this issue Aug 29, 2018
Merged
synhershko pushed a commit that referenced this issue Sep 29, 2018
@suren1525 @synhershko
Update UpdateManager.cs (#127)
8ab2f8f 
#98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@synhershko @suren1525