Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .NET 4.0 target framework version to NuGet package #85

Merged
merged 2 commits into from
May 18, 2016
Merged

Add .NET 4.0 target framework version to NuGet package #85

merged 2 commits into from
May 18, 2016

Conversation

FWennerdahl
Copy link

Allows for building for either .NET 3.5 or 4.0.

Both are included in the NuGet package.

Also updated instructions for packaging.

Frank Wennerdahl added 2 commits May 16, 2016 12:19
Added Release 4.0 configuration for Framework and Updater
77d7904 
Made dependency on Framework specifically 3.5 in:
- Feedbuilder
- WinFormsSampleApp
- WPFSampleApp
Updated nuspec-file to contain both targets
00c5dc2 
Also updated instructions for creating a nuget-package
@robinwassen
Copy link
Collaborator

After building Release 3.5

PS C:\dev\NAppUpdate\src\NAppUpdate.Framework> netversion .\Updater\updater.exe
v2.0.50727
PS C:\dev\NAppUpdate\src\NAppUpdate.Framework> netversion .\bin\Release\net35\NAppUpdate.Framework.dll
v2.0.50727

After building Release 4.0

PS C:\dev\NAppUpdate\src\NAppUpdate.Framework> netversion .\Updater\updater.exe
v4.0.30319
PS C:\dev\NAppUpdate\src\NAppUpdate.Framework> netversion .\bin\Release\net40\NAppUpdate.Framework.dll
v4.0.30319

Nuget content:

PS C:\dev\NAppUpdate\src\NAppUpdate.Framework> netversion .\NAppUpdate.Framework.0.4.0.0_nupkg\lib\net35\NAppUpdate.Framework.dll
v2.0.50727
PS C:\dev\NAppUpdate\src\NAppUpdate.Framework> netversion .\NAppUpdate.Framework.0.4.0.0_nupkg\lib\net40\NAppUpdate.Framework.dll
v4.0.30319

Looks good to me, merging.

@robinwassen robinwassen merged commit 36b7c8f into synhershko:master May 18, 2016
This was referenced May 18, 2016
Closed
Closed
@robinwassen robinwassen added this to the 0.5.0.0 milestone May 18, 2016
@robinwassen robinwassen mentioned this pull request May 18, 2016
Closed
@FWennerdahl FWennerdahl deleted the add-net40-target-framework-configuration branch June 2, 2016 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@FWennerdahl @robinwassen