Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SY-1194 Adjust Box Border Radius + Tank & Box Background Color #819

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

pjdotson
Copy link
Contributor

@pjdotson pjdotson commented Sep 9, 2024

Fix Pull Request Template

Key Information

Description

Adjusted the border radius on the box and added a border radius picker. Also added a background color picker for the tank and the box.

Basic Readiness Checklist

  • I have performed a self-review of my code.
  • I have added sufficient regression tests to cover the changes to CI.
  • I have added relevant tests to cover the changes or exposing bugs.
  • I have verified code coverage targets are met.

Additional Notes

  • These changes deal with concurrency.
  • These changes affect UI.

Manual QA Additions

  • I have updated the Release Candidate template
    with necessary manual QA steps to test my change.

Reviewer Checklist

  • Sufficient test coverage of new additions.
  • Verified all steps in readiness checklists.
  • UI changes have been tested.
  • style and formatting is consistent.
  • Reviewed any relevant changes to concurrent code for safety.
  • Sufficient comments and clarity of code.

@pjdotson pjdotson added the pluto Pluto UI components related label Sep 9, 2024
@pjdotson pjdotson self-assigned this Sep 9, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.82645% with 120 lines in your changes missing coverage. Please review.

Project coverage is 46.38%. Comparing base (69b7349) to head (15e63ee).

Files with missing lines Patch % Lines
pluto/src/vis/schematic/Forms.tsx 0.00% 44 Missing ⚠️
pluto/src/vis/schematic/primitives/Primitives.tsx 0.00% 40 Missing ⚠️
pluto/src/vis/schematic/Symbols.tsx 0.00% 21 Missing ⚠️
pluto/src/vis/schematic/registry.ts 0.00% 15 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               rc     #819      +/-   ##
==========================================
- Coverage   46.42%   46.38%   -0.04%     
==========================================
  Files        1086     1086              
  Lines       67811    67869      +58     
  Branches     3510     3510              
==========================================
  Hits        31478    31478              
- Misses      35285    35343      +58     
  Partials     1048     1048              
Flag Coverage Δ
pluto 35.43% <0.82%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pjdotson pjdotson merged commit 7cc4012 into rc Sep 13, 2024
34 checks passed
@pjdotson pjdotson deleted the sy-1194-box-border-radius-tank-background-color branch September 13, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pluto Pluto UI components related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants