Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all tests passed #252

Closed
lbcsy opened this issue May 1, 2024 · 2 comments
Closed

Not all tests passed #252

lbcsy opened this issue May 1, 2024 · 2 comments

Comments

@lbcsy
Copy link

lbcsy commented May 1, 2024

Start to look into mORMot 2, run tests first and got 4 failures:

  • Dmi smbios: 45 assertions passed 1.82ms
    ! - SID: 1 / 794 FAILED 7.41ms
  • Quick select: 4,015 assertions passed 187.13ms
  • TSynCache: 408 assertions passed 1.12ms
  • TSynFilter: 1,005 assertions passed 7.92ms
  • TSynValidate: 677 assertions passed 2.37ms
  • TSynLogFile: 62 assertions passed 814us
  • TSynUniqueIdentifier: 1,300,004 assertions passed 549.14ms
    200000 ComputeNew in 7.01ms i.e. 27.2M/s, aver. 35ns
    Total failed: 1 / 20,487,289 - Core base FAILED 7.22s
    ...
    1000 URI parametrized execute in 977us i.e. 0.9M/s, aver. 977ns
    ! - DNS and LDAP: 3 / 1,069 FAILED 981.90ms
    time.google.com : 2024-05-01 09:48:49.965Z = 2024-05-01 09:48:50.359Z
  • RTSP over HTTP: 2,100 assertions passed 294.72ms
  • RTSP over HTTP buffered write: 2,100 assertions passed 281.98ms
  • TTunnelLocal: 9,120 assertions passed 195.46ms
  • IP addresses: 53 assertions passed 1.56ms
  • THttpPeerCache: 14,013 assertions passed 231.56ms
    2000 messages in 2ms i.e. 0.9M/s, aver. 1us, 182.7 MB/s
    10000 altered in 725us i.e. 13.1M/s, aver. 72ns, 2.4 GB/s
    Total failed: 3 / 37,700 - Network protocols FAILED 2.01s
@synopse
Copy link
Owner

synopse commented May 1, 2024

Which compiler do you use?
Which version of the source code and statics are you using?
On which operating system are you running it?
On which computer are your running it?
Do you have access to an unrestricted/unproxied Internet connection?
What is the log content?
Can you debug a little and report which actual Check() failed?

The automated tests are currently passing:
https://luti.tranquil.it/history/tis-test-mormot2
So I guess this is due to some specificity on your system.

Please use the forum for such discussion.
Closing this issue here because it is not reproducible.

@synopse synopse closed this as completed May 1, 2024
@lbcsy
Copy link
Author

lbcsy commented May 1, 2024

It seems the SID tests do not cover the case where user is created and linked to Azure Acitve Directory, i.e., my user's SID starts with 'S-1-12-1-', thus below checking in the test failed:
CurrentRawSid(s1, wttProcess); CurrentRawSid(s2, wttThread); Check(SidCompare(pointer(s1), pointer(s2)) = 0); s := RawSidToText(s1); CheckUtf8(IdemPChar(pointer(s), 'S-1-5-'), s); // domain users are S-1-5-21-*, but LOCAL_SYSTEM is S-1-5-18

synopse pushed a commit that referenced this issue May 1, 2024
- e.g. if the user is created and linked to Azure Acitve Directory
- as reported by #252 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants