extract format for rails/convert_rails_test_request_methods_4_2_to_5_0

Author: flyerhzm

lib/rails/convert_rails_test_request_methods_4_2_to_5_0.rb

@@ -7,13 +7,13 @@
     functional test:
 
     ```ruby
-    get :show, { id: user.id }, { notice: 'Welcome' }, { admin: user.admin? }
+    get :show, { id: user.id, format: :json }, { notice: 'Welcome' }, { admin: user.admin? }
     ```
 
     =>
 
     ```ruby
-    get :show, params: { id: user.id }, flash: { notice: 'Welcome' }, session: { admin: user.admin? }.
+    get :show, params: { id: user.id }, flash: { notice: 'Welcome' }, session: { admin: user.admin? }, as: :json
     ```
 
     integration test:
@@ -29,13 +29,17 @@
     ```
   EOS
 
+  if_gem 'rails', { gte: '5.0' }
+
   helper_method :make_up_hash_pair do |key, argument_node|
-    if argument_node.to_source != 'nil'
-      if argument_node.type == :hash
-        "#{key}: #{add_curly_brackets_if_necessary(argument_node.to_source)}"
-      else
-        "#{key}: #{argument_node.to_source}"
-      end
+    next if argument_node.to_source == 'nil'
+
+    if argument_node.type == :hash
+      new_value = argument_node.children.reject { |pair_node| pair_node.key.to_value == :format }
+        .map(&:to_source).join(', ')
+      "#{key}: #{add_curly_brackets_if_necessary(new_value)}"
+    else
+      "#{key}: #{argument_node.to_source}"
     end
   end
 
@@ -47,12 +51,14 @@
       with_node type: 'send', message: message do
         next unless node.arguments.size > 1
         next unless node.arguments[1].type == :hash
-        next if node.arguments[1].has_key?(:params)
+        next if node.arguments[1].key?(:params)
 
+        format_value = node.arguments[1].hash_value(:format)
         options = []
         options << make_up_hash_pair('params', node.arguments[1])
         options << make_up_hash_pair('flash', node.arguments[2]) if node.arguments.size > 2
         options << make_up_hash_pair('session', node.arguments[3]) if node.arguments.size > 3
+        options << "as: #{format_value.to_source}" if format_value
         replace_with "#{message} {{arguments.first}}, #{options.compact.join(', ')}"
       end
     end
@@ -66,7 +72,7 @@
       with_node type: 'send', message: message do
         next unless node.arguments.size > 1
         if node.arguments[1].type == :hash &&
-             (node.arguments[1].has_key?(:params) || node.arguments[1].has_key?(:headers))
+             (node.arguments[1].key?(:params) || node.arguments[1].key?(:headers))
           next
         end
 

spec/rails/convert_rails_test_request_methods_4_2_to_5_0_spec.rb

@@ -11,7 +11,7 @@
       "
       class PostsControllerTest < ActionController::TestCase
         def test_show
-          get :show, { id: user.id }, { notice: 'Welcome' }, { admin: user.admin? }
+          get :show, { id: user.id, format: :json }, { notice: 'Welcome' }, { admin: user.admin? }
         end
 
         def test_index
@@ -32,7 +32,7 @@ def test_destroy
       "
       class PostsControllerTest < ActionController::TestCase
         def test_show
-          get :show, params: { id: user.id }, flash: { notice: 'Welcome' }, session: { admin: user.admin? }
+          get :show, params: { id: user.id }, flash: { notice: 'Welcome' }, session: { admin: user.admin? }, as: :json
         end
 
         def test_index