This repository has been archived by the owner on May 27, 2024. It is now read-only.
Local variable geoSeries eclipses member field #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's me that is. This piece of code is. It must have been forgotten or something. The serialization part seriously lacks of tests Thanks for catching this |
|
Sorry, what about a pub.dev update? |
|
It's planned: as soon as I find the time to do it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am I stupid or GeoJsonPolygon.serializeFeature is broken? Local variable geoSeries eclipses member field geoSeries in that method resulting in _buildGeoJsonFeature been always fed an empty list.
That entire loop seems to be just out of place.