-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add FizzBuzz By AgileSamuraiBaseCamp
- Loading branch information
syobochim
authored and
syobochim
committed
Apr 22, 2014
1 parent
b4a7e4e
commit d932824
Showing
2 changed files
with
70 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package Chapter1; | ||
|
||
public class FizzBuzz { | ||
public String convert(int src) { | ||
|
||
if(multiply(src, 3 * 5)) { | ||
return "FizzBuzz"; | ||
} | ||
if(multiply(src, 3)){ | ||
return "Fizz"; | ||
} | ||
if(multiply(src, 5)) { | ||
return "Buzz"; | ||
} | ||
|
||
return String.valueOf(src); | ||
} | ||
|
||
private boolean multiply(int src, int base) { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. |
||
return src % base == 0; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
package Chapter1; | ||
|
||
import org.junit.Before; | ||
import org.junit.Test; | ||
|
||
import static org.hamcrest.CoreMatchers.is; | ||
import static org.junit.Assert.assertThat; | ||
|
||
public class FizzBuzzTest { | ||
FizzBuzz sut; | ||
|
||
@Before | ||
public void setup() { | ||
sut = new FizzBuzz(); | ||
} | ||
|
||
@Test | ||
public void _1を入力したら1を返すべき() { | ||
assertThat(sut.convert(1), is("1")); | ||
} | ||
|
||
@Test | ||
public void _2を入力したら2を返すべき() { | ||
assertThat(sut.convert(2) , is("2")); | ||
} | ||
|
||
@Test | ||
public void _3を入力したらFizzを返すべき() { | ||
assertThat(sut.convert(3), is("Fizz")); | ||
} | ||
|
||
@Test | ||
public void _6を入力したらFizzを返すべき() { | ||
assertThat(sut.convert(6), is("Fizz")); | ||
} | ||
|
||
@Test | ||
public void _5を入力したらBuzzを返すべき() { | ||
assertThat(sut.convert(5), is("Buzz")); | ||
} | ||
|
||
@Test | ||
public void _15を入力したらFizzBuzzを返すべき() { | ||
assertThat(sut.convert(15), is("FizzBuzz")); | ||
} | ||
|
||
} |
multiply
は掛け算って意味?になると思うので、返り値はbooleanでなくintなどを想像してしまいます。あと、処理的にはsrcをbaseで割り切れるかを判定しているので、割り切れるって意味のdivisibleを使ってisDivisible
とかどうでしょう?あと、変数名srcは適当すぎるので、もう少し説明的な変数名にしてあげたほうが良さそうです。