Skip to content

Commit

Permalink
add FizzBuzz By AgileSamuraiBaseCamp
Browse files Browse the repository at this point in the history
  • Loading branch information
syobochim authored and syobochim committed Apr 22, 2014
1 parent b4a7e4e commit d932824
Show file tree
Hide file tree
Showing 2 changed files with 70 additions and 0 deletions.
23 changes: 23 additions & 0 deletions src/Chapter1/FizzBuzz.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package Chapter1;

public class FizzBuzz {
public String convert(int src) {

if(multiply(src, 3 * 5)) {
return "FizzBuzz";
}
if(multiply(src, 3)){
return "Fizz";
}
if(multiply(src, 5)) {
return "Buzz";
}

return String.valueOf(src);
}

private boolean multiply(int src, int base) {

This comment has been minimized.

Copy link
@tenten0213

tenten0213 Apr 23, 2014

Contributor

multiplyは掛け算って意味?になると思うので、返り値はbooleanでなくintなどを想像してしまいます。あと、処理的にはsrcをbaseで割り切れるかを判定しているので、割り切れるって意味のdivisibleを使ってisDivisibleとかどうでしょう?

あと、変数名srcは適当すぎるので、もう少し説明的な変数名にしてあげたほうが良さそうです。

This comment has been minimized.

Copy link
@tenten0213

tenten0213 Apr 23, 2014

Contributor

コードは長くなるけど、以下は参考になると思うので目を通してみてください!

return src % base == 0;
}

}
47 changes: 47 additions & 0 deletions test/Chapter1/FizzBuzzTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package Chapter1;

import org.junit.Before;
import org.junit.Test;

import static org.hamcrest.CoreMatchers.is;
import static org.junit.Assert.assertThat;

public class FizzBuzzTest {
FizzBuzz sut;

@Before
public void setup() {
sut = new FizzBuzz();
}

@Test
public void _1を入力したら1をすべき() {
assertThat(sut.convert(1), is("1"));
}

@Test
public void _2を入力したら2をすべき() {
assertThat(sut.convert(2) , is("2"));
}

@Test
public void _3を入力したらFizzをすべき() {
assertThat(sut.convert(3), is("Fizz"));
}

@Test
public void _6を入力したらFizzをすべき() {
assertThat(sut.convert(6), is("Fizz"));
}

@Test
public void _5を入力したらBuzzをすべき() {
assertThat(sut.convert(5), is("Buzz"));
}

@Test
public void _15を入力したらFizzBuzzをすべき() {
assertThat(sut.convert(15), is("FizzBuzz"));
}

}

0 comments on commit d932824

Please sign in to comment.