Clang compiler settings break clang-cl compilation on windows

[fknfilewalker]

Environment

• OS: Windows
• Compiler clang-cl

[syoyo]

You should describe details

[fknfilewalker]

Oh yes sorry

In the cmake the following line gets executed when the compiler used is clang.

tinyexr/CMakeLists.txt

Line 46 in 2a5ea89

set_source_files_properties(${TINYEXR_SOURCES} PROPERTIES COMPILE_FLAGS "-Weverything -Werror -Wno-padded -Wno-c++98-compat-pedantic -Wno-documentation -Wno-unused-member-function")

The problem here is that there are some warnings that get turned into errors now on the windows side making the code not compile with clang-cl.

So either we fix the code in tinyexr.cc so that these warnings/errors for windows get resolved or we deactivate these compiler flags for clang-cl on windows.

[syoyo]

Ah, o=it is needed to wrap it with MSVC to detect clang-cl.

if (MSVC) 
  if (CMAKE_CXX_COMPILER_ID SQTEQUAL "Clang")
    // clang-cl
  else() 
    // cl.exe
  endif()
endif ()

You can contribute! PR is much appreciated.