[TASK] Restructure github workflows #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restructues the github workflow, having one testset per coreversion, exploded by matrix mutations (per core version). We will also make sure all steps are executed, even if one step fails, except it fails early (composer req/install), so we can get all failures in one go, instead of fixing the first one, push, get next error etc. Currently only one testset is included for core v10, which will get a second testset later on for core v11 and php matrix for v11. All steps are executed on push or pull_request. But no rules without exceptions, and so we have some special conditions: - phpstan (only for composerInstallMax steps/mutations) - functional sqlite (only for nightly or pull_request, not for push) - functional postgres (only for nightly or pull_request, not for push) Big wins from this refactoring: - minimize count of parallel jobs which needs to be executed - only install composer packages once per core, php-version and min/max mutation With that, we can ommit to cache composer artifacts, as we do not have another job needing that combination for the same workflow run, which eventually could solve #71 .
|
See https://github.com/sbuerk/brofix/actions/runs/1496062299 for |
|
Structure makes sense. Nice work. I love it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request restructues the github workflow, having one testset
per core version, exploded by matrix mutations (per core version).
We will also make sure all steps are executed, even if one step fails,
except it fails early (composer req/install), so we can get all failures
in one go, instead of fixing the first one, push, get next error etc.
Currently only one testset is included for core v10, which will get a
second testset later on for core v11 and php matrix for v11.
All steps are executed on push or pull_request. But no rules without
exceptions, and so we have some special conditions:
Big wins from this refactoring:
With that, we can ommit to cache composer artifacts, as we do not have
another job needing that combination for the same workflow run, which
eventually could solve #71 .