Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined default slot when rendering complex components #26

Merged
merged 2 commits into from
Feb 9, 2020

Conversation

tzolkincz
Copy link

When there are some complex components in Vue - i.e. dynamically created objects, $el in default slot can be undefined before rendering is completed. That would create Tribute error: Error: [Tribute] Must pass in a DOM node or NodeList.

@syropian
Copy link
Owner

syropian commented Feb 9, 2020

Makes sense, thanks!

@syropian syropian merged commit c459034 into syropian:master Feb 9, 2020
@tzolkincz
Copy link
Author

Thanks for fast merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants