Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Traceback support to thrown Exceptions #18

Closed
wants to merge 4 commits into from
Closed

Add Traceback support to thrown Exceptions #18

wants to merge 4 commits into from

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Dec 15, 2016

I wanted to be able to see the traceback of where the promise was rejected during a p.get()

  • This maintains the traceback if there was a thrown Exception in the reason.
  • On p.get(), I added a raise with the original traceback to see where the ACTUAL traceback occurred -- not the traceback of the p.get()
  • added tests to demonstrate the addition of a 'traceback' attribute to the reason exception

I didn't see instructions on how to run the tests so i updated setup.py to run pytest with python setup.py test

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 97.083% when pulling 8f8306d on addyess:master into b4ec8f1 on syrusakbary:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 97.083% when pulling 8f8306d on addyess:master into b4ec8f1 on syrusakbary:master.

@coveralls
Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 0ad0b59 on addyess:master into b4ec8f1 on syrusakbary:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0ad0b59 on addyess:master into b4ec8f1 on syrusakbary:master.

@coveralls
Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling d1d1522 on addyess:master into b4ec8f1 on syrusakbary:master.

@coveralls
Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 5148371 on addyess:master into b4ec8f1 on syrusakbary:master.

@tlmurphy
Copy link

@syrusakbary Can this be merged? Seems valuable.

@addyess addyess mentioned this pull request Apr 11, 2017
@syrusakbary
Copy link
Owner

Closing in favor of #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants