Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the loss of traceback #55

Merged
merged 2 commits into from
Jun 22, 2018
Merged

fix the loss of traceback #55

merged 2 commits into from
Jun 22, 2018

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Apr 19, 2018

this fix removes repr(e) who will lose the stack trace of the original exception

@ocavue ocavue changed the title fix the loss of traceback WIP: fix the loss of traceback Apr 20, 2018
@ocavue
Copy link
Contributor Author

ocavue commented Apr 20, 2018

I removed repr(e) because that will lose my stack trace information. It's hard to debug when I have thirty data loader and the exception only provide 'NoneType' object is not iterable.
I also removed Data loader batch_load_fn function raised an Exception, which is a sweet but unnecessary message. It's easy to know that this error comes from a batch_load_fn function when you know which line raise it.

this fix removes `repr(e)` who will lose the stack trace of the original exception
@ocavue ocavue changed the title WIP: fix the loss of traceback fix the loss of traceback Apr 20, 2018
@syrusakbary
Copy link
Owner

Thanks for the fix! Merging

@syrusakbary syrusakbary merged commit c3db53e into syrusakbary:master Jun 22, 2018
@ocavue
Copy link
Contributor Author

ocavue commented Jun 22, 2018

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants