Use WeakKeyDictionary for caching types in is_future_like #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 19, 2019 15:25
This allows types to be garbage collected if they are not referenced any more elsewhere, and can prevent out-of-memory issues in applications that dynamically create new types and use them in Promises.
mypy complained that WeakKeyDictionary is not a Dict[type, bool].
alex-verve
pushed a commit
to alex-verve/graphene
that referenced
this pull request
May 15, 2020
it has following fixes: * Make Promise and Dataloader thread-safe syrusakbary/promise#81 * Fix memory leak on dynamically created types syrusakbary/promise#76 * and more https://github.com/syrusakbary/promise/releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows types to be garbage collected if they are not referenced
any more elsewhere, and can prevent out-of-memory issues in applications
that dynamically create new types and use them in Promises.
This fixes issue #75 (possible out-of-memory if dynamically generated types are used in Promises).