fix(agent, kspm-collector, rapid-response, node-analyzer): Set test rollout namespace based on required service accounts #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertoBarba
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Hey @IgorEulalio, i suppose the aim for this PR is to set clearly the namespace where those resources will be defined. If that's so you should have put the namespace key inside the metadata object while, right now, u did put it in labels 😅
| description: Sysdig Admission Controller using Sysdig Secure inline image scanner | ||
| type: application | ||
| version: 0.14.21 | ||
| version: 0.14.22 |
There was a problem hiding this comment.
This bump shouldn't be needed
| @@ -1,8 +1,9 @@ | |||
| apiVersion: v1 | |||
| kind: Pod | |||
| metadata: | |||
There was a problem hiding this comment.
You need to bump the agent chart version
AlbertoBarba
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.