Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improve tests on conditions and reasons for hcloud machine server with hcloud mock #1010

Closed
wants to merge 3 commits into from

Conversation

aniruddha2000
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #943

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>
@guettli
Copy link
Contributor

guettli commented Aug 15, 2024

@aniruddha2000 this PR is open since several months. What do you think: are you able to finish it during the next weeks, or is it better to close the PR?

@janiskemper
Copy link
Contributor

if we close it then we'll lose it right? I'd like to keep the code but this is certainly not the highest prio right now @guettli

@guettli
Copy link
Contributor

guettli commented Aug 16, 2024

if we close it then we'll lose it right? I'd like to keep the code but this is certainly not the highest prio right now @guettli

No, the changes are not lost. I close it now. We can start again from here.

@guettli guettli closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test whether conditions are set
3 participants