-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Continuous Benchmarking #166
Comments
Quote from github-action-benchmark's future work. If this CI run is enabled for PRs, the benchmark charts will update with each pull request. Since we must first confirm a performance improvement before updating the benchmark charts, this might not be what we desire. In other words, we need to discuss about how the PR is doing before updating the benchmark chart. Or, is it acceptable to update the benchmark chart with each PR? And one more thing, may I know if @qwe661234 is working on this issue? If not, I could help to write the CI script if the above concern is OK. |
Please move forward. Before submitting pull request(s), do write down your plans and communicate here. |
If the results generated by the CI are deterministic, we can certainly treat them as references for incremental development. However, due to our current lack of confidence, it is premature to define a clear strategy at this stage. |
My plan is as follows:
|
We can set the threshold to trigger the generation of benchmark comparison, for example 0.5x worse than before, default is 2x worse than before. |
We shall track
Agree. |
The 'pull_request_target' event is utilized for the benchmark action due to its ability to update data in the 'gh-pages' branch, which is crucial for visualization on GitHub Pages. The 'pull_request' event lacks the necessary 'GITHUB_TOKEN' for this task. Furthermore, 'workflow_dispatch' event is added to enable the initial setup and running of the benchmark. This permits the storage of base benchmark data for future comparisons. To prevent redundant executions, a filter has been implemented to exclude the merging push event. Close #166
github-action-benchmark provides a GitHub Action for continuous benchmarking, and we can utilize it to track performance regressions.
Expected output:
Reference:
The text was updated successfully, but these errors were encountered: