Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate CI/CD test for gdbstub #130

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

RinHizakura
Copy link
Collaborator

We can't get expected result when running make gdbstub-test under the old version of rv32emu. That's because the implementation of rv_step changed from returning after stepping single instruction to returning after a block execution. To solve the issue, I simply take gdbstub mode as a special case for rv_step, which will return directly after executing one instruction, so we can check whether the breakpoint hit after every return.

After the changed, we can add the test of gdbstub mode in CICD now. The workflow of CICD is also changed a little bit since we'll need riscv32-gdb for the test on gdbstub.

@jserv jserv changed the title Introduce CICD test for gdbstub mode on rv32emu Consolidate CI/CD test for gdbstub May 15, 2023
@jserv jserv merged commit 558fcea into sysprog21:master May 16, 2023
@jserv
Copy link
Contributor

jserv commented May 16, 2023

Thank @RinHizakura for contributing!

@RinHizakura RinHizakura deleted the gdbstub-dev branch November 22, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants