Improve red-black tree performance #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jserv
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Meanwhile, resolve the concerns raised by CodeQL. |
|
TODO:
|
EagleTw
force-pushed
the
master
branch
2 times, most recently
from
e1753a8
to
87c7f21
Compare
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
| internal_map_path_entry_t path[RB_MAX_DEPTH]; | ||
| internal_map_path_entry_t *pathp; | ||
| rbt_node_init(node); | ||
| /* Wind. */ |
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
jserv
reviewed
May 21, 2023
| rbtn_black_set(left); | ||
| if (pathp == path) { | ||
| rbtree->root = left; | ||
| /* Nothing to summarize -- the subtree rooted at the |
There was a problem hiding this comment.
See if "Nothing to summarize" makes sense or not. We shall ignore the handling of summary.
jserv
reviewed
May 21, 2023
EagleTw
force-pushed
the
master
branch
5 times, most recently
from
a72f62f
to
0035e63
Compare
jserv
reviewed
May 21, 2023
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
| * Each node in the red-black tree consumes at least 1 byte of space (for the | ||
| * linkage if nothing else, so there are a maximum of sizeof(void *) << 3 rb | ||
| * tree nodes in any process (and thus, at most sizeof(void *) << 3 nodes in any | ||
| * rb tree). The choice of algorithm bounds the depth of a tree to twice the |
There was a problem hiding this comment.
Improve the English writing.
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
jserv
reviewed
May 24, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jserv
requested changes
May 24, 2023
There was a problem hiding this comment.
Prepare test program(s) for map.[ch] which appear in directory tests/map.
Example: https://github.com/sysprog21/rv32emu/tree/master/tests/cache
jserv
reviewed
May 24, 2023
EagleTw
force-pushed
the
master
branch
2 times, most recently
from
e40ed35
to
7541a26
Compare
jserv
reviewed
May 24, 2023
| map_r_r(obj, node, parent, grandparent, uncle); | ||
| int cmp; | ||
| map_node_t *ret = rbtree->root; | ||
| while (ret && (cmp = (rbtree->cmp)(keynode->key, ret->key)) != 0) { |
There was a problem hiding this comment.
Replace 0 with _CMP_EQUAL for readability.
jserv
reviewed
May 24, 2023
| path->node = rbtree->root; | ||
| for (pathp = path; pathp->node; pathp++) { | ||
| int cmp = pathp->cmp = (rbtree->cmp)(node->key, pathp->node->key); | ||
| if (cmp == 0) { |
There was a problem hiding this comment.
I would propose the following:
switch (cmp) {
case _CMP_LESS:
pathp[1].node = rbnode_get_left(pathp->node);
break;
case _CMP_GREATER:
pathp[1].node = rbnode_get_right(pathp->node);
break;
default: /* _CMP_EQUAL */
break;
}
jserv
reviewed
May 24, 2023
| /* If there is no left child, keep going up until there is a left child */ | ||
| it->prev = it->node; | ||
| it->node = rb_parent(it->node); | ||
| map_t tree = (map_t) malloc(sizeof(map_head_t)); |
There was a problem hiding this comment.
No cast is required. That is,
map_t tree = malloc(sizeof(map_head_t));
|
Close in favor of incoming revised pull request for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map.[ch]is the C Implementation for C++ std::map using red-black tree. It works well, but there is room for improvements.Close #29