-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CI ubuntu version to 24.04 #467
Upgrade CI ubuntu version to 24.04 #467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmarks
Benchmark suite | Current: f2e41a8 | Previous: 66dec82 | Ratio |
---|---|---|---|
Dhrystone |
1589.12 Average DMIPS over 10 runs |
4.12 Average DMIPS over 10 runs |
0.0025926298832057997 |
Coremark |
1402.631 Average iterations/sec over 10 runs |
0.004 Average iterations/sec over 10 runs |
0.000002851783541073882 |
This comment was automatically generated by workflow using github-action-benchmark.
The introduction of clang-format-18 does change the program's indentation. I am a bit worried about the inconsistency. |
Would we like to stick with clang-format-12? :) |
The better way is to ensure the |
0124836
to
134214b
Compare
I did a quick pass on this documentation and can't quite find out what rules that are introduced in clang-format-18 that we are violating. Is there a way for clang-format to print out what rules we have violated that caused the format error to be raised? |
CONTRIBUTING.md states the supported clang-format version is 12 or later. It is vital to ensure the compatibility for CI pipeline. |
134214b
to
7d39f8a
Compare
Required dependencies are all updated, such as - clang-format-18 - LLVM 18 - fix an issue with pip3 install - fix an issue with testing gdbstub (notice that the riscv-gnu-toolchain releases are built using ubuntu 22.04, thus, we need to install libpython3.10 for the CI pipeline to work) Reference: - https://stackoverflow.com/questions/75608323/how-do-i-solve-error-externally-managed-environment-every-time-i-use-pip-3 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
7d39f8a
to
f2e41a8
Compare
With clang-format lint action, we can flexibly specify the versions of clang-format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase the latest master
branch.
Close in favor of #497 |
Required dependencies are all updated, such as
to install libpython3.10 for the CI pipeline to work)
Reference: