Added condition to check batteries for charging state #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icate they are connected to power, and removed the hard block so it would only warn the user if they are about to install via battery
|
I may need to rethink this if statement in the code, if they are on a laptop with AC off and discharging battery they may get 2 warnings instead of 1. I need to add a boolean statement here, so if in case either condition is satisfied, the msg will show up. |
…icate they are connected to power, and removed the hard block so it would only warn the user if they are about to install via battery
|
no idea why VSCodium truncated the proceedInstall() line, its missing a chunk. EDIT: Fixed |
sladiri
reviewed
Jun 4, 2024
…atement for readability.
…it rill return early
|
I think I like it in this current form.. just not merging yet as I need some time to test it properly and that hasn't come up yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added condition to check batteries for charging state which would indicate they are connected to power, and removed the hard block so it would only warn the user if they are about to install via battery