Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image broken on Avatar and Image docs page #1222

Closed
ronaldleung1 opened this issue Oct 23, 2020 · 4 comments · Fixed by #1233
Closed

Image broken on Avatar and Image docs page #1222

ronaldleung1 opened this issue Oct 23, 2020 · 4 comments · Fixed by #1233

Comments

@ronaldleung1
Copy link

Broken Avatar Images
The examples in the docs for the Image and Avatar component contain images that are broken. It appears that the images are from contrast.now.sh but Vercel gives a 404 error and says that the deployment was disabled.

To Reproduce
Go to https://theme-ui.com/components/image or https://theme-ui.com/components/avatar

On Image Docs
image_docs

On Avatar Docs
avatar_docs

contrast.now.sh is also used in other files across the theme-ui repo.
So it seems that someone should notify the owner, @/jxnblk, of contrast.now.sh to resolve this, or include the image as a file in the static folder.

@ronaldleung1 ronaldleung1 changed the title Image is broken on Avatar and Image docs page Image broken on Avatar and Image docs page Oct 23, 2020
@atanasster
Copy link
Collaborator

Do you have a good source of images - or select one from a library and I can submit a PR.
For example if you go
https://theme-ui-design-system.netlify.app/docs/components-theme-ui-avatar--overview and in the Controls section click on randomize - those are face images from AWS using fakerjs.

@ronaldleung1
Copy link
Author

Hmm... this unfortunately doesn't appear to solve the problem, since the images are still broken on the docs :( Any reason why?

Also, should we use the theme-ui logo instead? If someone could guide me through a PR for this (not sure if this is weird to ask), I'd greatly appreciate it.

@atanasster
Copy link
Collaborator

@googol88 - I believe its not deployed yet.

I think you are right that #1233 is using the gatsby logo, and it should probably use the theme-ui logo. Thanks a lot for the link - I created #1235.

I have temporarily published the site if you can please confirm
image: https://theme-ui-draft.netlify.app/components/image
avatar: https://theme-ui-draft.netlify.app/components/avatar

@hasparus
Copy link
Member

hasparus commented Nov 5, 2020

Yup, we shouldn't have closed the issue.

@jxnblk I've cherry-picked a fix for this to previous. Could you set up docs to be deployed from that branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants