Add typecheck scripts #1072
Merged
Add typecheck scripts #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
reviewed
Jul 19, 2020
| @@ -6,7 +6,8 @@ | |||
| "peerDependencies": { | |||
| "gatsby": "^2.13.1", | |||
| "react": "^16.8.0", | |||
| "react-dom": "^16.8.0" | |||
| "react-dom": "^16.8.0", | |||
| "typecheck": "tsc --noEmit" | |||
There was a problem hiding this comment.
Slipped into the wrong line here :)
There was a problem hiding this comment.
oh wow :D what have I done...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
I added a typecheck step as mentioned by @blainekasten in #668 (comment).
It feels a bit wasteful to run this on every change, and it could be probably made faster with some TS
compositeprojects and GitHub actions wizardry, but I guess it's not bad for now.The .d.ts for for @theme-ui/color-modes was needed to type values reexported from theme-ui.
This should make Theme UI TypeScript feel less "early access" for users.
BTW I tried using
lerna execinstead oflerna runto leave the package.json files in packages intact, but it resulted in incomprehensible bash one-liner 😅