Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: support other tag systems like ctags #38

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

silvio
Copy link
Contributor

@silvio silvio commented Jun 22, 2017

This completes a067f9d "Add TAGS target".

Signed-off-by: Silvio Fricke silvio.fricke@gmail.com

@keszybz
Copy link
Member

keszybz commented Jun 22, 2017

Hm, maybe we should make this unconditional? It's a bit awkward that when e.g. etags is not installed, and one runs ninja TAGS, the error is "unknown target". It'd actually be better to have the command run and fail, e.g. with "bash: etags : command not found...". So maybe change the command to

['env', tag_prog, ...]

without detecting that tag_prog is present? It'd reduce boilerplate and make the whole thing easier to use.

@silvio silvio force-pushed the support-other-tagingtools branch from 40e4581 to 62e0e1f Compare June 26, 2017 19:04
@silvio
Copy link
Contributor Author

silvio commented Jun 26, 2017

Better now @keszybz?

@keszybz
Copy link
Member

keszybz commented Jun 26, 2017

Yeah, that's nice, except one small thing: the target should be TAGS tags not etags. I was mimicking automake here, see ftp://prep.ai.mit.edu/old-gnu/Manuals/automake-1.7.2/html_node/automake_102.html#SEC102. (It was "TAGS" before your patch, but it seems that "tags" is the documented target name.)

@silvio silvio force-pushed the support-other-tagingtools branch from 62e0e1f to c7149f7 Compare June 27, 2017 18:40
@silvio
Copy link
Contributor Author

silvio commented Jul 3, 2017

ping @keszybz

@keszybz
Copy link
Member

keszybz commented Jul 3, 2017

Ah, I missed the updated. It's best to leave a comment after pushing, because github does not send out notifications about a push.

@keszybz keszybz merged commit 02fbbdb into systemd:master Jul 3, 2017
@silvio
Copy link
Contributor Author

silvio commented Jul 3, 2017

Thanks @keszybz

@silvio silvio deleted the support-other-tagingtools branch July 3, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants