Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing packages on arch #377

Closed
wants to merge 1 commit into from
Closed

Add missing packages on arch #377

wants to merge 1 commit into from

Conversation

kkuehlz
Copy link

@kkuehlz kkuehlz commented Oct 31, 2019

With Bootable=no mkosi will fail on arch with the following errors.

Generating locales...
/usr/bin/locale-gen: line 33: sed: command not found
.UTF-8/usr/bin/locale-gen: line 35: sed: command not found
.../usr/bin/locale-gen: line 38: sed: command not found

/tmp/alpm_PENqPM/.INSTALL: line 3: chmod: command not found
/tmp/alpm_PENqPM/.INSTALL: line 4: chmod: command not found
error: command failed to execute correctly

The coreutils package installs chmod, and the sed package installs sed.

kkuehlz added a commit to kkuehlz/systemd that referenced this pull request Oct 31, 2019
@kkuehlz
Fix mkosi on Arch Linux
9e05564 
/* test compression */
XZ compression finished (38280 -> 11756 bytes, 30.7%)
sh: diff: command not found
Assertion 'system(cmd) == 0' failed at src/journal/test-compress.c:198,
function test_compress_stream(). Aborting.

The journal compression test shells out to diff, so include diffutils as
a BuildPackage on Arch.

Remaining fixes in systemd/mkosi#377
@kkuehlz kkuehlz mentioned this pull request Oct 31, 2019
Merged
@marcosfrm
Copy link

What about https://www.archlinux.org/news/base-group-replaced-by-mandatory-base-package-manual-intervention-required/ ?

@kkuehlz
Copy link
Author

kkuehlz commented Oct 31, 2019

@marcosfrm Thanks! Look better now?

@kkuehlz kkuehlz mentioned this pull request Oct 31, 2019
Merged
@behrmann
Copy link
Contributor

behrmann commented Nov 6, 2019

Just this morning I thought anout the base package change. Good to see somebody already put in the work. :)

Some comments:

  1. run_pacman(["-Si", "base"]) should probably be -Sqi instead.
  2. packages = set() seems a bit unneccary, you could just do packages = instead of packages |= in the if branch
  3. The regular expression approach seems a bit fragile, if the output of pacman changes, this might break. Since the announcement is quite clear, that the base package must be installed to request support, I guess we should just install the base package, which is now also a lot slimmer than the base package group used to be, i.e. the whole section could just be changed to
packages = { "base" }

What do you think @marcosfrm?

@marcosfrm
Copy link

  1. The regular expression approach seems a bit fragile, if the output of pacman changes, this might break. Since the announcement is quite clear, that the base package must be installed to request support, I guess we should just install the base package, which is now also a lot slimmer than the base package group used to be, i.e. the whole section could just be changed to

I agree.

@craftyguy
Copy link

  1. The regular expression approach seems a bit fragile, if the output of pacman changes, this might break. Since the announcement is quite clear, that the base package must be installed to request support, I guess we should just install the base package, which is now also a lot slimmer than the base package group used to be, i.e. the whole section could just be changed to
packages = { "base" }

I can confirm that this change to the proposed patch works.

@lucasdemarchi
Copy link
Contributor

packages = { "base" }

Lgtm. Could any of you update this PR?

behrmann added a commit to behrmann/mkosi that referenced this pull request Nov 8, 2019
@behrmann
arch: use base package instead of base group
b0f5300 
Arch has changed its base package group to a meta package that pulls in several
other packages as dependencies. It is slimmer than the package group was before
and necessary to request support, so we can (and should) install it in full.

https://www.archlinux.org/news/base-group-replaced-by-mandatory-base-package-manual-intervention-required/

Original-Author: @keur
Closes: systemd#377
@behrmann behrmann mentioned this pull request Nov 8, 2019
Merged
@behrmann
Copy link
Contributor

behrmann commented Nov 8, 2019

I've reworked the patch, since @craftyguy said it works, and opened #381, since I obviously can't edit this PR.

@kkuehlz
Copy link
Author

kkuehlz commented Nov 9, 2019

Closing in favor of #381

Sorry I didn't get back to you guys. Was in the wilderness with no Internet.

@kkuehlz kkuehlz closed this Nov 9, 2019
keszybz pushed a commit to systemd/systemd-stable that referenced this pull request Nov 19, 2019
@kkuehlz @keszybz
Fix mkosi on Arch Linux
c430e8a 
/* test compression */
XZ compression finished (38280 -> 11756 bytes, 30.7%)
sh: diff: command not found
Assertion 'system(cmd) == 0' failed at src/journal/test-compress.c:198,
function test_compress_stream(). Aborting.

The journal compression test shells out to diff, so include diffutils as
a BuildPackage on Arch.

Remaining fixes in systemd/mkosi#377

(cherry picked from commit 9e05564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kkuehlz @marcosfrm @behrmann @craftyguy @lucasdemarchi