use LONG instead of BYTEs for binary fields #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We hard-code little-endian byte sequences for binary fields, but that clearly doesn't work on big endian architectures like s390x. Switch to single LONG per 4-bytes field, so that the right thing happens automatically. Displaying notes found in: .note.package Owner Data size Description readelf: /usr/bin/bash: Warning: note with invalid namesz and/or descsz found at offset 0x0 readelf: /usr/bin/bash: Warning: type: 0x7e1afeca, namesize: 0x04000000, descsize: 0x78000000, alignment: 4
bluca
added a commit
to bluca/systemd
that referenced
this pull request
Mar 28, 2022
…DATA The first three fields of a note are binary, so they are subject to flipping due to endianess. Instead of a stream of bytes, just use the native 4-bytes type so that it gets encoded automatically. Implemented in the tools via: systemd/package-notes#31
keszybz
pushed a commit
to systemd/systemd
that referenced
this pull request
Mar 28, 2022
…DATA The first three fields of a note are binary, so they are subject to flipping due to endianess. Instead of a stream of bytes, just use the native 4-bytes type so that it gets encoded automatically. Implemented in the tools via: systemd/package-notes#31
keszybz
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hard-code little-endian byte sequences for binary fields, but
that clearly doesn't work on big endian architectures like s390x.
Switch to single LONG per 4-bytes field, so that the right thing
happens automatically.
Displaying notes found in: .note.package
Owner Data size Description
readelf: /usr/bin/bash: Warning: note with invalid namesz and/or descsz
found at offset 0x0
readelf: /usr/bin/bash: Warning: type: 0x7e1afeca, namesize:
0x04000000, descsize: 0x78000000, alignment: 4