When Nice= is used, clamp to RLIMIT_NICE #14465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, push to the closest possible Nice priority setting. Replaces: systemd#11397
poettering
force-pushed
the
setprio-rework
branch
from
ab99d40
to
75997c3
Compare
|
Hmm, CI failure looks like a segfault in valgrind. Which appears unrelated? weird... |
Yup, this is unfortunately a flake... I'll give it one more try |
|
@mrc0mmand nice! it passed this time! thanks! |
keszybz
approved these changes
Jan 8, 2020
|
|
||
| /* rlimit of 30 equals nice level of -10 */ | ||
| if (setrlimit(RLIMIT_NICE, &RLIMIT_MAKE_CONST(30)) < 0) { | ||
| /* If this fails we are probably unprivielged or in a userns of some kind, let's skip |
poettering
added a commit
to poettering/systemd
that referenced
this pull request
Jan 8, 2020
As pointed out on: systemd#14465 (comment)
Merged
poettering
added a commit
to poettering/systemd
that referenced
this pull request
Jan 8, 2020
As pointed out on: systemd#14465 (comment)
mrc0mmand
pushed a commit
that referenced
this pull request
Jan 8, 2020
As pointed out on: #14465 (comment)
Yamakuzure
pushed a commit
to elogind/elogind
that referenced
this pull request
Feb 1, 2020
As pointed out on: systemd/systemd#14465 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a warm-up for #11397 which was too close to being ready to leave it hanging. I did some minor updates (mostly what I pointed out in my most recent review on that PR), plus added a test case.
Since this is mostly @xnox i left his authorship of the commit intact.
/cc @xnox