This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
Update define.amd of dummy define to be an object #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**before:**
```JavaScript
function define(){}; define.amd = true;
```
**after**
```JavaScript
function define(){}; define.amd = {};
```
Reasoning: both require.js and `System.amdDefine` expose `.amd` property as an `Object` and that would be expected sometimes for UMD wrappers like that one `lodash` uses:
```JavaScript
if (typeof define == 'function' && typeof define.amd == 'object' && define.amd) {
// ...
}
```
And "normal/simplified" wrappers wouldn't be affected.
|
Thanks I forgot this is the right behaviour! |
guybedford
added a commit
that referenced
this pull request
Aug 22, 2014
Update define.amd of dummy define to be an object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after
Reasoning: both require.js and
System.amdDefineexpose.amdproperty as anObjectand that would be expected sometimes for UMD wrappers like that onelodashuses:And "normal/simplified" wrappers wouldn't be affected.