Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Corrected a typo in redeem rewards prompt. #19

Merged
merged 3 commits into from
Jan 15, 2022

Conversation

FriendsFerdinand
Copy link

@FriendsFerdinand FriendsFerdinand commented Aug 31, 2021

Description

Corrected a minor typo in the RedeemStacking.js component to tell users that only one transaction is necessary to redeem their STX.

@FriendsFerdinand FriendsFerdinand changed the title [minor] Corrected a typo in stacking rewards prompt. It should be 1 (one) transaction to get redeemable STX. [minor] Corrected a typo in redeem rewards prompt. Aug 31, 2021
@Zk2u
Copy link

Zk2u commented Aug 31, 2021

ty for the pr -- however you will have a transaction for each of the cycles you stacked for.

maybe change it to "transaction(s)" or add some logic to display one or the other based on if there are multiple or not then we can get it merged 🧀

…y show further instructions when there are rewards available
@FriendsFerdinand
Copy link
Author

FriendsFerdinand commented Sep 2, 2021

Sure thing. Would have done this sooner but life stuff, etc.. Anyways, I made it so the minimum amount of information appears to not confuse users.
This is what it looks like while it's loading:
While_loading
Here's the screen when there are no rewards:
When_no_rewards

1 reward cycle:
With_1_Cycle

4 reward cycles:
With_4_cycles

Also, here's the transaction that is created on clicking a button:
image

@Zk2u
Copy link

Zk2u commented Sep 4, 2021

LGTM - @SyInvidia @diopitis can y'all review this, then we can get it merged.

@Zk2u Zk2u added Good first issue Good for newcomers Low Low priority QOL Quality of life UI Something todo with a UI labels Sep 4, 2021
@Zk2u Zk2u merged commit a0e08de into syvita:prod Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers Low Low priority QOL Quality of life UI Something todo with a UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants