Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safety checks for common fixes #198

Closed
szapp opened this issue Oct 11, 2019 · 1 comment
Closed

Add safety checks for common fixes #198

szapp opened this issue Oct 11, 2019 · 1 comment

Comments

@szapp
Copy link
Owner

szapp commented Oct 11, 2019

Common fixes like the trigger collision fix or the attack run fix should be wrapped in safety checks in case they have been applied outside of GFA. It’s only possible to check if they had been applied prior to GFA initialization, not after.

Common fixes include:

  • Attack run fix
  • Trigger collision fix
  • Dropped projectile fix
@szapp
Copy link
Owner Author

szapp commented Oct 12, 2019

The trigger collision fix was interfering with a script provided here. This conflict was resolved. The attack run fix does not interfere with other implementations (script, system pack) and work alongside each other/are safely overwritten. The dropped projectile fix is not implemented else where.

@szapp szapp closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant