Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

Add missing "get" and "set" property options #260

Closed
wants to merge 2 commits into from
Closed

Add missing "get" and "set" property options #260

wants to merge 2 commits into from

Conversation

neilime
Copy link

@neilime neilime commented Mar 12, 2019

As describe in mongoose doc, we can define "get" and "set" options to be used as property getter and setter : https://mongoosejs.com/docs/api.html#schematype_SchemaType-set

As describe in mongoose doc, we can define "get" and "set" options to be used as property getter and setter : https://mongoosejs.com/docs/api.html#schematype_SchemaType-set
@coveralls
Copy link

coveralls commented Mar 12, 2019

Coverage Status

Coverage decreased (-0.3%) to 90.887% when pulling b522bd1 on neilime:patch-1 into 287a209 on szokodiakos:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.228% when pulling c2aa647 on neilime:patch-1 into 287a209 on szokodiakos:master.

@Ben305
Copy link
Collaborator

Ben305 commented Mar 12, 2019

@neilime Would you mind adding some tests?

@anirbanagp
Copy link

It is still not available in downloaded package. can you please check?

@neilime
Copy link
Author

neilime commented Apr 10, 2019

@Ben305, sorry for the delay, I have added some tests

@hasezoey

This comment has been minimized.

This was referenced Aug 2, 2019
hasezoey referenced this pull request in typegoose/typegoose Aug 4, 2019
- adding set option for nonVirtual setting functions

closes szokodiakos#260
hasezoey referenced this pull request in typegoose/typegoose Aug 4, 2019
- adding set option for nonVirtual setting functions

closes szokodiakos#260
hasezoey referenced this pull request in typegoose/typegoose Aug 4, 2019
- adding set option for nonVirtual setting functions

closes szokodiakos#260
@hasezoey
Copy link
Contributor

hasezoey commented Aug 10, 2019

this can be closed in favor of a123c49 and d357d37 (6.0.0)

@Ben305

@Ben305 Ben305 closed this Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants