-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAERO shuts down after a couple of minutes when running with libacars 1.2.0 #3
Comments
Not a whole lot of information... Do you get any error messages? What do they say? |
Hi Tomasz, I have no error messages, the JAERO program shuts down normally ..as though the "Exit" control has been selected. The program runs for 1-3 minutes approx. before closing down, the log shows the data and I could not see any particular repeated msg at the time of shutdown. Would a copy of the Log be of any use to you? Or some other detail? |
The ACARS file itself would not be of much use. I'll try to reproduce this when I'll have access to a Win10 machine. Meanwhile, can you please try to copy both libacars.dll and zlib1.dll from the new libacars release into the JAERO directory? In theory, libacars should run correctly with zlib1.dll which is bundled with JAERO, but in theory theory and practice are the same thing, while in practice they often are not. |
I have tried the prog with both new files and also with the new libacars and the "old" zlib1 it does not make any difference,the prog still shuts itself down after a short time. I also tried setting the RX to a vacant(no signal) frequency .....the prog runs and runs..! As soon as I tune a active frequency the prog shuts itself down after a couple of minutes. |
A couple of hours straight with JAERO 1.0.4.10 and libacars.dll 1.2.0 on L-band 10500 today - no issues. Initially I suspected that there might be some problem with handling compressed MIAM messages, but no, they seem to be decoded OK. I needed about an hour to catch one though (they are quite rare on L-band). So I'm about to close this issue now, but if anybody is able to reproduce this reliably and provide me with more clues, then we might reopen it. |
Szpajder. I need help I'm having same problem with jaero with new libacar 1.2.0 shuth itself after 2 minutes .I replace with old libacard works for hours I'm using windows 10 with all updates everything else run good. |
As I mentioned before, so far I was unable to reproduce this problem, so I can't even start troubleshooting it... Try launching cmd.exe (Start -> Run -> cmd.exe), then go to the directory where JAERO is installed (probably |
Thank you sir will try that let you know if it work.
…On Mon, Jul 29, 2019, 2:10 PM Tomasz Lemiech, ***@***.***> wrote:
As I mentioned before, so far I was unable to reproduce this problem, so I
can't even start troubleshooting it...
Try launching cmd.exe (Start -> Run -> cmd.exe), then go to the directory
where JAERO is installed (probably cd c:\program files\JAERO or similar)
and run JAERO from there by typing .\JAERO? When the program exits, maybe
there will be some error message printed to the cmd window?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AMXYFWHDMFLD72E2IY5LQJTQB4XADA5CNFSM4G3GM4I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BRQEI#issuecomment-516102161>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMXYFWFTVH26BYBLMQQ22MLQB4XADANCNFSM4G3GM4IQ>
.
|
Hi Tomasz I did what you asked and no errors at all.
But I noticed jaero when running for 1 to 2 minutes the freq:5149.55 in
butom right
.
My processor is a i7-3740k @3.50 3.90 memory 16.0 gb
Thank you
…On Mon, Jul 29, 2019, 2:31 PM tony paulino, ***@***.***> wrote:
Thank you sir will try that let you know if it work.
On Mon, Jul 29, 2019, 2:10 PM Tomasz Lemiech, ***@***.***>
wrote:
> As I mentioned before, so far I was unable to reproduce this problem, so
> I can't even start troubleshooting it...
>
> Try launching cmd.exe (Start -> Run -> cmd.exe), then go to the directory
> where JAERO is installed (probably cd c:\program files\JAERO or similar)
> and run JAERO from there by typing .\JAERO? When the program exits,
> maybe there will be some error message printed to the cmd window?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#3?email_source=notifications&email_token=AMXYFWHDMFLD72E2IY5LQJTQB4XADA5CNFSM4G3GM4I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BRQEI#issuecomment-516102161>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AMXYFWFTVH26BYBLMQQ22MLQB4XADANCNFSM4G3GM4IQ>
> .
>
|
Unfortunately this doesn't help much. That's the problem with Windows - it's really hard to troubleshoot such issues. Maybe compiling and running JAERO and libacars with debugging enabled could shed some light on this. |
@tonypaulino another idea - if the problem occurs so often, could you then record the sound? You could then repeat the decoding of the fragment that caused the program to terminate to see if the problem occurs every time. If so, please share the recording - I will check if I can reproduce the problem. Thank you in advance. |
hi Tomasz this is the recording from 54 west .
thank you
https://mega.nz/#F!Q59FiSAK!UTPpeQCQxn_G5mwpeR6zOg
…On Mon, Aug 5, 2019 at 4:35 PM Tomasz Lemiech ***@***.***> wrote:
@tonypaulino <https://github.com/tonypaulino> another idea - if the
problem occurs so often, could you then record the sound? You could then
repeat the decoding of the fragment that caused the program to terminate to
see if the problem occurs every time. If so, please share the recording - I
will check if I can reproduce the problem. Thank you in advance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AMXYFWGH3HBT6PCPWX4E74TQDCFHJA5CNFSM4G3GM4I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3S72UQ#issuecomment-518389074>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMXYFWBWLMTDNQOJZCII2PTQDCFHJANCNFSM4G3GM4IQ>
.
|
Everything fine with this file. It decoded up to the end, no crashes, no
program exits. Win 10, JAERO 1.0.4.10, libacars.dll taken from 1.2.0 binary
release.
Do you get a crash every time when playing back this file? If yes - at
which point in time?
|
Thank you Tomasz for testing.
The problem start when a big Mi masage starts.
Thank you
|
You mean MIAM?
How do you know this? There are no MIAM messages in this recording.
|
Tomasz I will send you that log .start like MI so I figure that what
making this to shutitself
Sorry I tot mi wood the start Miami masage .
The thing I know only shut itself on this mode 10500 on big masage 600 1200
Thay go all day without any problems.
Tomasz thank you
…On Tue, Aug 6, 2019, 9:54 AM Tomasz Lemiech, ***@***.***> wrote:
You mean MIAM?
How do you know this? There are no MIAM messages in this recording.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AMXYFWE62NTBYFS2YSFUCJDQDF7BNA5CNFSM4G3GM4I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VGYWQ#issuecomment-518679642>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMXYFWES7ARIA2MDL5INO3LQDF7BNANCNFSM4G3GM4IQ>
.
|
hi TOMASZ
https://mega.nz/#!kw0CyaIY!qPBbmGm1hRvyMl9NX4s1cV18Feihv9QPVzoZwy_3iNc
thank you again
…On Tue, Aug 6, 2019 at 10:08 AM tony paulino ***@***.***> wrote:
Tomasz I will send you that log .start like MI so I figure that what
making this to shutitself
Sorry I tot mi wood the start Miami masage .
The thing I know only shut itself on this mode 10500 on big masage 600
1200 Thay go all day without any problems.
Tomasz thank you
On Tue, Aug 6, 2019, 9:54 AM Tomasz Lemiech, ***@***.***>
wrote:
> You mean MIAM?
>
> How do you know this? There are no MIAM messages in this recording.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#3?email_source=notifications&email_token=AMXYFWE62NTBYFS2YSFUCJDQDF7BNA5CNFSM4G3GM4I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VGYWQ#issuecomment-518679642>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AMXYFWES7ARIA2MDL5INO3LQDF7BNANCNFSM4G3GM4IQ>
> .
>
|
MIAM Single Transfer:
MIAM CORE Data, version 1:
PDU Length: 224
Aircraft ID: .B-1069
Msg num: 57
ACK: required
Compression: deflate
Encoding: ISO #5
ACARS:
Label: H1 Sublabel: DF
Message:
A350,000054,1,1,TB000000/REP054,01,01;H01,054,01,01,4110,00744,.B-1069,3,0,06,08,19,14,58,29,080/H02,ZBAA
KBOS,CHH481 ,S0285,S0385,ACMR190625/H03,Traffic Policing FRi481 /HHHHH,C
85,1
,S0287.4E,08,19,14,58XXXXXXXXXXXXXXXXXXXX8XXXXXXXXXXXXXXXXXXXX8000000000114,181
,7,3481
,S028/B,58XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/B,1800000000058XXXXXXXXXX/C,58XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/C,1800000000018XXXXXXXXXX/D,58XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/D,1800000124058XXXXXXXXXX/E,58XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/E,1800000000058XXXXXXXXXX/F,58XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/F,1800000000058XXXXXXXXXX/:
-- CRC check failed
now i know what a MIAM looks like i apologise
…On Tue, Aug 6, 2019 at 10:36 AM tony paulino ***@***.***> wrote:
hi TOMASZ
https://mega.nz/#!kw0CyaIY!qPBbmGm1hRvyMl9NX4s1cV18Feihv9QPVzoZwy_3iNc
thank you again
On Tue, Aug 6, 2019 at 10:08 AM tony paulino ***@***.***>
wrote:
> Tomasz I will send you that log .start like MI so I figure that what
> making this to shutitself
> Sorry I tot mi wood the start Miami masage .
> The thing I know only shut itself on this mode 10500 on big masage 600
> 1200 Thay go all day without any problems.
> Tomasz thank you
>
> On Tue, Aug 6, 2019, 9:54 AM Tomasz Lemiech, ***@***.***>
> wrote:
>
>> You mean MIAM?
>>
>> How do you know this? There are no MIAM messages in this recording.
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#3?email_source=notifications&email_token=AMXYFWE62NTBYFS2YSFUCJDQDF7BNA5CNFSM4G3GM4I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VGYWQ#issuecomment-518679642>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AMXYFWES7ARIA2MDL5INO3LQDF7BNANCNFSM4G3GM4IQ>
>> .
>>
>
|
@G7gqw, are you able to take an audio recording which crashes the program reliably? |
https://mega.nz/#!9dEwyQCL!0kufEBqbCd9fozkOqAJ4MNO2SIiy8rw_SgPzGnm3SFo |
I see this one on the middle channel (repeated once):
The next message after the first occurrence is:
and the next one after the second occurence is:
On the third channel I see this one:
and this one comes next:
So still no luck from my side - everything runs fine. It might be that the bug is somewhere else in JAERO code, not necessarily in libacars. It's just libacars triggering it in a non-deterministic way (depending on the memory layout, different versions of the libraries present in the system, etc). |
Hi Tomasz, thanks for trying,we all appreciate your hard work and time, maybe it will sort out in any future updates to JAERO/libacars. |
Whoops sorry ..hit the wrong button.. |
You can try version 1.3.0, released today, if it makes any difference. I doubt this, but... never say never. |
Tried v1.3.0, still shuts down after a short time, I have just noticed that an acars.log is saved but the plane.log isn't unless I close JAERO before it crashes. Not sure if this is significant....thanks for your help and time. |
extra info....when JAERO is restarted after a "crash" there is no sign of the acars.log data that has been recorded to file showing in the "acars" window, shows up ok if the prog is terminated before it "crashes" and then restarted..hope this helps |
This is expected, because the acars.log file is synced to disk after every ACARS message. This makes it easier to follow the file with "tail" program, as it grows. What is plane.log file? I don't have such a thing.
The whole contents of the acars window is saved into JAERO settings file on clean exit and restored from this file on next startup. When there is no clean exit, the contents does not get saved. This is why you don't get recent content in this window after a crash. |
Understood about the acars.log, my bad on the "Plane.Log" , I should have written "Plane Log" and was referring to the window that opens via the button between "settings" and "audio mute" |
I think there are two separate problems here.
For the next release of JAERO I'll include a precompiled shared library of the latest libarcs using the same build environment that will build JAERO as well as the bug fix for issue 2. However, issue 1 might become a problem again in the future when newer versions of libarcs are released. |
Thank you so much for yours and Tomasz time and energy on this,looking forward to the next release,still enjoying voice decoding on the current version, great s/w from you both. |
Thanks @jontio for your input on this topic. I build binary releases for Windows by cross-compiling libacars under Linux using x86_64-w64-mingw32 as a target architecture. If memory serves me well, the last release has been built with gcc 9.1.0. However the gcc different probably is not (and should not) be the root cause of this problem. As I mentioned, I did a couple of hours of tests using binary packages of JAERO 1.0.4.10 and libacars 1.3.0 under Windows 10, both with L-band and C-band signals and so far I was unable to reproduce this problem. So it must have something to do with the environment the program is being run in (like versions of some system DLLs in Windows, etc). How do you know that the crash occured in |
Hi Thomas, As the crash didn't happen when I was looking in I had compiled everything but libacars myself and then copied your v1.3.0 release of I was playing through some audio and noticed the following message result would cause JAERO to crash if
Here is a link to an audio clip with this message in it, JAERO compiled by me, and libacars.dll compiled by you. On my Windows system that crashes every time the audio sample is played... https://drive.google.com/open?id=1cwLwa4cupGrr2sUYVjOttw8_Hebr3XoU Here is the following with the same build of JAERO but this time using the libacars.dll I compiled myself. Playing the same audio clip as above it doesn't crash on my system... https://drive.google.com/open?id=1kqzn263AYjXQRb5t-zk-pdcG_IgVhQsB When it does crash playing the sample no useful debug information is given; just that JAERO returned with some negative exit code. I did try compiling JAERO in debug mode but still no useful information was given. I could be wrong but to me it seems like some sort of incompatibility between our two build environments or what we doing with them. I have noticed your build of Cheers, |
Just tested both versions on Windows 10 and both run fine - no crashes, CPDLC message decodes properly. There must be some other factor which we are missing here. |
Hi Thomas, That is interesting. I am now thinking it might be the CPU instruction set issue. The CPU I'm using supports the following extensions... MMX,SSE,SSE2,SSE3,SSSE3,SSE4.1,SSE4.2,EM64T and VT-x. Others such as AVX are unsupported. I ran the one that crashes for me using
Looking into the disassembly I see that this instruction is... => 0x0000000066309aef <+8207>: vmovdqa 0x60(%rsp),%xmm0
So that seems to be the problem. To solve it I suggest you disable AVX/AVX2/FMA instruction sets. I see there are some posts on the Internet about people trying to disable these instruction sets. It looks like you have to add Cheers, |
Great catch @jontio, thanks! However it's also quite puzzling, because:
However I see this: movdqa .LC1(%rip), %xmm0 This is an SSE2 instruction and it requires dest. memory address to be aligned on a 16-byte boundary or a general-protection exception may be generated. I suspect this is what's happening here. Anyway, this instruction can be eliminated from the code simply by changing
Can you guys check this build please? |
Hi Tomasz, I had a quick look to see what functions called what and int asn_sprintf(la_vstring *vstr, /* Destination vstring pointer */
asn_TYPE_descriptor_t *td, /* ASN.1 type descriptor */
const void *struct_ptr, /* Structure to be printed */
int indent); /* Indentation level */
I have decompiled both your built DLLs (the one from your releases and the one with https://drive.google.com/open?id=1xg5xPZj4qiuRxQHcDai1INpO7vZDshNq As you can see there are I tried the the -o2 optimization build you did. It too crashes. This time it crashes in __pformat_float at 662f29af on an AVX instruction... .text:662f2980 <__pformat_float>:
.text:662f2980 56 push %rsi
.text:662f2981 53 push %rbx
.text:662f2982 48 83 ec 78 sub $0x78,%rsp
.text:662f2986 44 8b 42 10 mov 0x10(%rdx),%r8d
.text:662f298a db 29 fldt (%rcx)
.text:662f298c 48 89 d3 mov %rdx,%rbx
.text:662f298f 45 85 c0 test %r8d,%r8d
.text:662f2992 79 0d jns 0x662f29a1
.text:662f2994 c7 42 10 06 00 00 00 movl $0x6,0x10(%rdx)
.text:662f299b 41 b8 06 00 00 00 mov $0x6,%r8d
.text:662f29a1 db 7c 24 60 fstpt 0x60(%rsp)
.text:662f29a5 48 8d 44 24 58 lea 0x58(%rsp),%rax
.text:662f29aa 48 89 44 24 20 mov %rax,0x20(%rsp)
=====> .text:662f29af c5 f9 6f 44 24 60 vmovdqa 0x60(%rsp),%xmm0
.text:662f29b5 48 8d 54 24 30 lea 0x30(%rsp),%rdx
.text:662f29ba 4c 8d 4c 24 5c lea 0x5c(%rsp),%r9
.text:662f29bf b9 03 00 00 00 mov $0x3,%ecx
.text:662f29c4 c5 f8 29 44 24 30 vmovaps %xmm0,0x30(%rsp)
.text:662f29ca e8 91 f6 ff ff callq 0x662f2060 <.text>
.text:662f29cf 44 8b 44 24 5c mov 0x5c(%rsp),%r8d
.text:662f29d4 48 89 c6 mov %rax,%rsi
.text:662f29d7 41 81 f8 00 80 ff ff cmp $0xffff8000,%r8d
.text:662f29de 74 40 je 0x662f2a20
.text:662f29e0 8b 4c 24 58 mov 0x58(%rsp),%ecx
.text:662f29e4 49 89 d9 mov %rbx,%r9
.text:662f29e7 48 89 c2 mov %rax,%rdx
.text:662f29ea e8 d1 fb ff ff callq 0x662f25c0 <__pformat_emit_float>
.text:662f29ef eb 0d jmp 0x662f29fe
.text:662f29f1 48 89 da mov %rbx,%rdx
.text:662f29f4 b9 20 00 00 00 mov $0x20,%ecx
.text:662f29f9 e8 82 f7 ff ff callq 0x662f2180 <__pformat_putc>
.text:662f29fe 8b 43 0c mov 0xc(%rbx),%eax
.text:662f2a01 8d 50 ff lea -0x1(%rax),%edx
.text:662f2a04 89 53 0c mov %edx,0xc(%rbx)
.text:662f2a07 85 c0 test %eax,%eax
.text:662f2a09 7f e6 jg 0x662f29f1
.text:662f2a0b 48 89 f1 mov %rsi,%rcx
.text:662f2a0e e8 4d 19 00 00 callq 0x662f4360 <__freedtoa>
.text:662f2a13 90 nop
.text:662f2a14 48 83 c4 78 add $0x78,%rsp
.text:662f2a18 5b pop %rbx
.text:662f2a19 5e pop %rsi
.text:662f2a1a c3 retq
.text:662f2a1b 0f 1f 44 00 00 nopl 0x0(%rax,%rax,1)
.text:662f2a20 8b 4c 24 58 mov 0x58(%rsp),%ecx
.text:662f2a24 49 89 d8 mov %rbx,%r8
.text:662f2a27 48 89 c2 mov %rax,%rdx
.text:662f2a2a e8 f1 f9 ff ff callq 0x662f2420 <__pformat_emit_inf_or_nan>
.text:662f2a2f 48 89 f1 mov %rsi,%rcx
.text:662f2a32 e8 29 19 00 00 callq 0x662f4360 <__freedtoa>
.text:662f2a37 90 nop
.text:662f2a38 48 83 c4 78 add $0x78,%rsp
.text:662f2a3c 5b pop %rbx
.text:662f2a3d 5e pop %rsi
.text:662f2a3e c3 retq
.text:662f2a3f 90 nop This I assume is a function in On Linux I believe that So it looks like AVX instructions aren't being disabled in the final DLL. Maybe the optimization commands like I am struggling to figure out what's happening here so I tried compiling a very simple program... #include <stdio.h>
#include <stdlib.h>
void main()
{
float a_rand_float=rand();
printf("test %f\n",a_rand_float);
}
So you can see it's wanting
Breaking on I didn't find any I don't think SSE2 instructions should be an issue. Cheers, |
Ahh, yes, correct. grep without -r didn't catch it.
Right, all these
|
Hi Tomasz, Thanks for that. I tried that out and yes that works fine. So yup, that was the problem. That was an interesting puzzle. Cheers, |
Great work Guys, |
Released as 1.3.1. https://github.com/szpajder/libacars/releases/tag/v1.3.1 Thanks to all involved. |
Hi ,just tried your latest libacars.dll (1.2.0) in latest JAERO 1.0.4.10 and using I7 win10/64bit, JAERO runs fine decoding voice but shuts down after a couple of minutes decoding data, I am recieving L-band from Alphasat . I swopped out the libacars .dll with the previous version and JAERO runs constantly with no problems apart from no MIAM decodes.......sorry ...
Cheers
Dave G7gqw
The text was updated successfully, but these errors were encountered: