-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New block type for 'surface' plots #57
base: master
Are you sure you want to change the base?
Conversation
Makes animation by clearing plot and re-drawing. It was suggested that this is the best solution as majority of time is drawing rather than updating the array anyway, see https://stackoverflow.com/a/45713451/13577592
Setting the z-axis limits needed to use |
Tests and documentation added. I think this is ready for review/merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic to me. Only thing that I notice is that docs/source/tutorial/surface.ipynb
and the gif, should probably be under docs/source/gallery/
.
Adds a new
Block
subclassSurface
to make surface plots using matplotlib'splot_surface()
method.Makes animation by clearing plot and re-drawing. It was suggested that this is the best solution as majority of time is drawing rather than updating the array anyway, see https://stackoverflow.com/a/45713451/13577592.
Making the vertical axis scale fixed doesn't work at the moment. Seems to be a bug with matplotlib'svmin
andvmax
arguments, see matplotlib/matplotlib#19870.Still needs tests and documentation.