-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select2 component rendering in Modal dialog #27
Comments
@rohitdev Have you managed to test this yet? Can we consider this issue resolved? |
@nickl- @t0m I think it's safe to close this one:
|
Closed: considered to have support of the community (17 days without any disagreements) |
This requires more than css. Some modals such as Bootstrap modal require focus to stay on the modal (which it should, IMO). If select2 needs to be at body level, then it should stopPropagation of the focusin event so the search input works and to prevent a focus war. |
@mattslocum Is this something purely lacking in the bootstrap implementations or would you consider this a more general shortcoming which should rather be addressed upstream? I am not against adding JS if it is required you are welcome to submit PRs for review.... |
I would rather it be addressed upstream I think. It is more the bootstrap integration where it shows itself, but any integration where there is other code listening to focus could cause a problem. Pull Request here: https://github.com/ivaynberg/select2/pull/2176/files |
Support added nicely done! |
https://github.com/ivaynberg/select2/issues/942
https://github.com/ivaynberg/select2/issues/1645
Is this issue solved in this select2-bootstrap-css component?
The text was updated successfully, but these errors were encountered: