Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select2 component rendering in Modal dialog #27

Closed
rohitdev opened this issue Aug 23, 2013 · 7 comments
Closed

Select2 component rendering in Modal dialog #27

rohitdev opened this issue Aug 23, 2013 · 7 comments

Comments

@rohitdev
Copy link

https://github.com/ivaynberg/select2/issues/942
https://github.com/ivaynberg/select2/issues/1645

Is this issue solved in this select2-bootstrap-css component?

@nickl-
Copy link
Collaborator

nickl- commented Jan 22, 2014

@rohitdev Have you managed to test this yet? Can we consider this issue resolved?

@fk
Copy link
Collaborator

fk commented Jan 26, 2014

@nickl- @t0m I think it's safe to close this one:

@nickl-
Copy link
Collaborator

nickl- commented Feb 11, 2014

Closed: considered to have support of the community (17 days without any disagreements)

@nickl- nickl- closed this as completed Feb 11, 2014
@mattslocum
Copy link

This requires more than css. Some modals such as Bootstrap modal require focus to stay on the modal (which it should, IMO). If select2 needs to be at body level, then it should stopPropagation of the focusin event so the search input works and to prevent a focus war.

https://github.com/ivaynberg/select2/pull/2176

@nickl-
Copy link
Collaborator

nickl- commented Mar 18, 2014

@mattslocum Is this something purely lacking in the bootstrap implementations or would you consider this a more general shortcoming which should rather be addressed upstream?

I am not against adding JS if it is required you are welcome to submit PRs for review....

@mattslocum
Copy link

I would rather it be addressed upstream I think. It is more the bootstrap integration where it shows itself, but any integration where there is other code listening to focus could cause a problem.

Pull Request here: https://github.com/ivaynberg/select2/pull/2176/files

@nickl-
Copy link
Collaborator

nickl- commented Mar 18, 2014

Support added nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants