-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the linux part of the firmware script #500
Improve the linux part of the firmware script #500
Conversation
I actually was thinking of making binaries that run only in macOS using pyinstaller. It would make a .tar file in macOS itself then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot use python3 on macOS since it's not shipped with it. User will have to install python3. So, either ship a binary with macOS or use Linux to rename.
c68f9f2
to
b17443c
Compare
|
b17443c
to
dbc4725
Compare
So we don't want user to install anything as far as macOS is considered. |
Also, don't make the user install any additional software on macOS, that includes python3 |
I am going to try to embed python, but that makes the firmware script huge and it needs custom build steps which are very finicky. The python packaging ecosystem is a huge mess, and apple makes it very hard to distribute stuff on macos. |
Or we could just use Linux to rename. I had said I'll prefer macOS, but since embedding python is difficult, it's better to stay on Linux. |
And if we want to embed, I guess pyinstaller is perfect for this scenario. |
dbc4725
to
bed552f
Compare
This just uses new mountpoints now, I will make a new PR with the python script running on macos |
cbd0ed5
to
91bc11f
Compare
56bf3e0
to
32a15fd
Compare
I fixed the requested changes. |
32a15fd
to
10cb2c4
Compare
It should work better now, and doesnt mess with mounts