Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postinstall.md #523

Closed
wants to merge 3 commits into from
Closed

Conversation

StudioCrash
Copy link

Little paragraph explaining the fix for tiny-dfr not loading on boot.

Little paragraph explaining the fix for tiny-dfr not loading on boot.
Fixed the new little paragraph explaining the fix for tiny-dfr not running on boot.
@@ -100,6 +100,11 @@ The steps to be followed vary depending upon the initramfs module loading mechan

## Setting up the Touch Bar

There's new touch bar software called tiny-dfr. Below are instructions on how to install it on various distros.

- Note: There is a bug causing tiny-dfr not to load in most distros if the file `/etc/tiny-dfr/config.toml` is blank.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this bug fixed? Why adding then?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hasn't been fixed yet. Or if it has, the fix isn't merged yet. I'm happy to remove these lines after the fix is merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have it in Ubuntu

AdityaGarg8/tiny-dfr@c2b3b23

@sharpenedblade
Copy link
Contributor

its fixed on most distros now (arch, eos, fedora, and ubuntu), so I think we can close this.

@AdityaGarg8 AdityaGarg8 closed this May 1, 2024
@StudioCrash
Copy link
Author

StudioCrash commented May 2, 2024 via email

@AdityaGarg8
Copy link
Member

Okay. I appreciate you helping me learn more about git and the process of making a pull request.

On Tue, Apr 30, 2024 at 6:14 PM Sharpened Blade @.> wrote: its fixed on most distros now (arch, eos, fedora, and ubuntu), so I think we can close this. — Reply to this email directly, view it on GitHub <#523 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3BBZ2MYULGL6TFLRCMJEPTZAAJU3AVCNFSM6AAAAABG7MBP2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBXGU2TCNZRHA . You are receiving this because you authored the thread.Message ID: @.>

For a first timer you did good :). The PR could actually have been merged, it was just that the issue got fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants