Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] my-view2.html does not show up #335

Closed
t2ym opened this issue Feb 7, 2020 · 0 comments
Closed

[demo] my-view2.html does not show up #335

t2ym opened this issue Feb 7, 2020 · 0 comments

Comments

@t2ym
Copy link
Owner

t2ym commented Feb 7, 2020

[demo] my-view2.html does not show up

Root Cause

  • As a side effect of the fix [vulnerability][acl] ACL is skipped for globals defined via defineProperty() and alike #325, window['__proto__'] access, which is for constructing the graph data from window object, window.__proto__ === Window.prototype object is tracked as __proto__ global object for ACL.
  • The missing global __proto__ ACL defaults to the default global object policy [S_GLOBAL], which does not allow Object.getOwnPropertyDescriptors() access and throws Cannot access __proto__

Fix

  • Skip __proto__ property in looping through the descriptors in my-view2.html
t2ym added a commit that referenced this issue Feb 7, 2020
…perty to avoid the side effect of the changes in Issue #325
@t2ym t2ym closed this as completed in a320024 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant