Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note explaining the rationale for Alpine 3.16 #1022

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

nicolomaioli
Copy link
Contributor

Closes #975

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  • Add a note explaining the rationale for recommending Alpine 3.16, while presenting an alternative solution for using Alpine 3.17 based images.

💯

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2022

⚠️ No Changeset found

Latest commit: be6b703

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Dec 27, 2022 at 7:07PM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Dec 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 96
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-nicolomaioli-docs-add-alpi-c27f77-t3-oss.vercel.app/

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@c-ehrlich c-ehrlich merged commit c9ea34b into t3-oss:next Dec 27, 2022
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: docs - Docker node:16-alpine requires setting engineType = "binary" for Prisma to work
2 participants