Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more db options #1622

Merged
merged 38 commits into from
Jan 20, 2024
Merged

feat: Add more db options #1622

merged 38 commits into from
Jan 20, 2024

Conversation

ronanru
Copy link
Contributor

@ronanru ronanru commented Oct 24, 2023

Closes #1617
Closes #1646

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Add a database selector, if user chose an ORM.


Screenshots

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: cfa68bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 0:03am

@vercel
Copy link

vercel bot commented Oct 24, 2023

@ronanru is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea here but there are stuff we need to make sure before merging this.

What's the dev story? Should we include a db container? Recommend something like DBngin? How should the developer get the database running as quickly as possible in dev, without drifting away from the production environment?


And as I previously commented, we are not adding neon.

@ronanru
Copy link
Contributor Author

ronanru commented Nov 2, 2023

What's the dev story? Should we include a db container?

I think adding a script that creates a db container is a great idea. I will add it in a future commit.

Edit: Added it

@juliusmarminge
Copy link
Member

juliusmarminge commented Jan 4, 2024

So sorry for the delay, but today I tested a lot of this out and I have to say awesome work!

However, using Bun, Drizzle and SQLite doesn't quite work, also Bun has it's own sqlite implementation which supposedly is faster etc. Should we use that? https://orm.drizzle.team/docs/get-started-sqlite#bun-sqlite

EDIT: hmm doesn't look like db push works for that :/

CleanShot 2024-01-04 at 16 26 44@2x

@juliusmarminge
Copy link
Member

juliusmarminge commented Jan 4, 2024

the DATABASE_URL for prisma+planetscale also doesn't work, you need to change the ssl query param:

- DATABASE_URL='mysql://user:pw@aws.connect.psdb.cloud/db?ssl={"rejectUnauthorized":true}'
+ DATABASE_URL='mysql://user:pw@aws.connect.psdb.cloud/db?sslaccept=strict' 

Fixed in 60914c7

@juliusmarminge
Copy link
Member

Current published version is 7.26.0-beta.4

@juliusmarminge
Copy link
Member

juliusmarminge commented Jan 12, 2024

So sorry for the delay, but today I tested a lot of this out and I have to say awesome work!

However, using Bun, Drizzle and SQLite doesn't quite work, also Bun has it's own sqlite implementation which supposedly is faster etc. Should we use that? https://orm.drizzle.team/docs/get-started-sqlite#bun-sqlite

EDIT: hmm doesn't look like db push works for that :/

CleanShot 2024-01-04 at 16 26 44@2x

I'm fine just not suppporting that combo to begin with, and let people open issue if they run into it 😅 ... Gonna merge this

Merged via the queue into t3-oss:main with commit 06b1bca Jan 20, 2024
266 of 267 checks passed
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Co-authored-by: juliusmarminge <julius0216@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: ci Relates to CI / GitHub Actions 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Prisma Edge Client feat: Add neon || planetscale to relation database options (postgres || mysql)
4 participants